HADOOP-17159. Make UGI support forceful relogin from keytab ignoring the last login time #2249

sguggilam · 2020-08-26T20:48:53Z

The original commit of PR #2197 was reverted. This is a revised version PR for Hadoop 3.

liuml07

+1

liuml07 · 2020-08-26T21:58:48Z

...mon-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java

+    reloginFromKeytab(checkTGT, false);
+  }
+
+  private void reloginFromKeytab(boolean checkTGT, boolean ignoreTimeElapsed)


nit: add javadoc for this method, OR name ignoreTimeElapsed with ignoreLastLoginTime to make it a bit clearer?

hadoop-yetus · 2020-08-26T23:32:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	28m 45s	trunk passed
+1 💚	compile	19m 38s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	16m 52s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 54s	trunk passed
+1 💚	mvnsite	1m 31s	trunk passed
+1 💚	shadedclient	16m 30s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 40s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 36s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 18s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 14s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s	the patch passed
+1 💚	compile	18m 51s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	18m 51s	the patch passed
+1 💚	compile	16m 50s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	16m 50s	the patch passed
+1 💚	checkstyle	0m 54s	the patch passed
+1 💚	mvnsite	1m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 2s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 39s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 34s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 29s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 57s	The patch does not generate ASF License warnings.
		162m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/1/artifact/out/Dockerfile
GITHUB PR	#2249
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 64ffc15c34e3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5e52955`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/1/testReport/
Max. process+thread count	3459 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-27T02:28:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	28m 37s	trunk passed
+1 💚	compile	19m 38s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	16m 57s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 57s	trunk passed
+1 💚	mvnsite	1m 29s	trunk passed
+1 💚	shadedclient	16m 37s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 38s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 32s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 18s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 16s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 51s	the patch passed
+1 💚	compile	18m 51s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	18m 51s	the patch passed
+1 💚	compile	16m 59s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	16m 59s	the patch passed
-0 ⚠️	checkstyle	0m 50s	hadoop-common-project/hadoop-common: The patch generated 1 new + 85 unchanged - 0 fixed = 86 total (was 85)
+1 💚	mvnsite	1m 31s	the patch passed
-1 ❌	whitespace	0m 0s	The patch 1 line(s) with tabs.
+1 💚	shadedclient	14m 5s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 33s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 31s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 55s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 49s	The patch does not generate ASF License warnings.
		161m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/2/artifact/out/Dockerfile
GITHUB PR	#2249
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 92e8ae0ef8af 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5e52955`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/2/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
whitespace	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/2/artifact/out/whitespace-tabs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/2/testReport/
Max. process+thread count	2175 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-27T05:52:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	32m 0s	trunk passed
+1 💚	compile	26m 33s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	21m 49s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 58s	trunk passed
+1 💚	mvnsite	1m 43s	trunk passed
+1 💚	shadedclient	19m 47s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 35s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 38s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 54s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 51s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 6s	the patch passed
+1 💚	compile	25m 37s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	25m 37s	the patch passed
+1 💚	compile	21m 40s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	21m 40s	the patch passed
+1 💚	checkstyle	0m 54s	the patch passed
+1 💚	mvnsite	1m 37s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	16m 7s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 28s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 26s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 38s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		194m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/3/artifact/out/Dockerfile
GITHUB PR	#2249
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux be826396fcd0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5e52955`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/3/testReport/
Max. process+thread count	3239 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2249/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

…the last login time (#2249) Contributed by Sandeep Guggilam. Signed-off-by: Mingliang Liu <liuml07@apache.org> Signed-off-by: Steve Loughran <stevel@apache.org>

…the last login time (apache#2249) Contributed by Sandeep Guggilam. Signed-off-by: Mingliang Liu <liuml07@apache.org> Signed-off-by: Steve Loughran <stevel@apache.org>

HADOOP-17159 Ability for forceful relogin in UserGroupInformation class

1c1f300

liuml07 self-requested a review August 26, 2020 21:56

liuml07 approved these changes Aug 26, 2020

View reviewed changes

sguggilam mentioned this pull request Aug 26, 2020

HADOOP-17159 Ability for forceful relogin in UserGroupInformation class #2197

Merged

Incorporate review comments

e6af89e

fix checkstyle

4c998ce

liuml07 merged commit d8aaa8c into apache:trunk Aug 27, 2020

liuml07 changed the title ~~HADOOP-17159 Ability for forceful relogin in UserGroupInformation class~~ HADOOP-17159. Make UGI support forceful relogin from keytab ignoring the last login time Aug 27, 2020

sguggilam mentioned this pull request Aug 27, 2020

HADOOP-17159. Make UGI support forceful relogin from keytab ignoring the last login time (branch-2.10) #2245

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-17159. Make UGI support forceful relogin from keytab ignoring the last login time #2249

HADOOP-17159. Make UGI support forceful relogin from keytab ignoring the last login time #2249

Uh oh!

sguggilam commented Aug 26, 2020 •

edited by liuml07

Loading

Uh oh!

liuml07 left a comment

Uh oh!

liuml07 Aug 26, 2020

Uh oh!

hadoop-yetus commented Aug 26, 2020

Uh oh!

hadoop-yetus commented Aug 27, 2020

Uh oh!

hadoop-yetus commented Aug 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HADOOP-17159. Make UGI support forceful relogin from keytab ignoring the last login time #2249

HADOOP-17159. Make UGI support forceful relogin from keytab ignoring the last login time #2249

Uh oh!

Conversation

sguggilam commented Aug 26, 2020 • edited by liuml07 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuml07 left a comment

Choose a reason for hiding this comment

Uh oh!

liuml07 Aug 26, 2020

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Aug 26, 2020

Uh oh!

hadoop-yetus commented Aug 27, 2020

Uh oh!

hadoop-yetus commented Aug 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sguggilam commented Aug 26, 2020 •

edited by liuml07

Loading