HADOOP-17255. JavaKeyStoreProvider fails to create a new key if the keystore is HDFS

[aajisaka]

Use the new rename API in JavaKeyStoreProvider#renameOrFail.

JIRA: https://issues.apache.org/jira/browse/HADOOP-17255

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	32m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	31m 44s	trunk passed
+1 💚	compile	24m 33s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	18m 48s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 47s	trunk passed
+1 💚	mvnsite	1m 23s	trunk passed
+1 💚	shadedclient	17m 53s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 30s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 29s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 24s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 22s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 55s	the patch passed
+1 💚	compile	24m 18s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	24m 18s	the patch passed
+1 💚	compile	18m 34s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	18m 34s	the patch passed
+1 💚	checkstyle	0m 48s	the patch passed
+1 💚	mvnsite	1m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	16m 3s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 27s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 26s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 44s	the patch passed
		_ Other Tests _
-1 ❌	unit	11m 33s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		212m 57s

Reason	Tests
Failed junit tests	hadoop.crypto.key.TestKeyProviderFactory

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2291/1/artifact/out/Dockerfile
GITHUB PR	#2291
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux e2b28d63239a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 1d6d0d8
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2291/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2291/1/testReport/
Max. process+thread count	1355 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2291/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[steveloughran]

+1 for the better errors. You know in #743 I'm going to make rename/3 public in FileSystem too, so we can move the code in distcp etc to using it?

[steveloughran]

Akira -I'm +1 on this...commit at your leisure

[aajisaka]

Thank you @steveloughran for your review. The unit test failure is related. I'll fix this before merging.

we can move the code in distcp etc to using it?

Agreed.

[jojochuang]

+1