Skip to content

HADOOP-14508. TestDFSIO throws NPE when set -sequential argument. #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wenxinhe wants to merge 2 commits into
base: trunk
Choose a base branch
from
+70 −5
Open

HADOOP-14508. TestDFSIO throws NPE when set -sequential argument. #231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a50dfe
HADOOP-14508. TestDFSIO throws NPE when set -sequential argument.
wenxinhe Jun 8, 2017
2039eb7
fix checkstyle
wenxinhe Jun 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 70 additions & 5 deletions ...lient/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/TestDFSIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ public class TestDFSIO implements Tool {
" [-size Size[B|KB|MB|GB|TB]]" +
" [-resFile resultFileName] [-bufferSize Bytes]" +
" [-storagePolicy storagePolicyName]" +
" [-erasureCodePolicy erasureCodePolicyName]";
" [-erasureCodePolicy erasureCodePolicyName]" +
" [-sequential]";

private Configuration config;
private static final String STORAGE_POLICY_NAME_KEY =
Expand Down Expand Up @@ -288,6 +289,62 @@ public void testTruncate() throws Exception {
bench.analyzeResult(fs, TestType.TEST_TYPE_TRUNCATE, execTime);
}

@Test (timeout = 10000)
public void testSequentialWrite() throws Exception {
FileSystem fs = cluster.getFileSystem();
bench.sequentialTest(fs, TestType.TEST_TYPE_WRITE,
DEFAULT_NR_BYTES, DEFAULT_NR_FILES);
}

@Test (timeout = 10000)
public void testSequentialRead() throws Exception {
FileSystem fs = cluster.getFileSystem();
bench.sequentialTest(fs, TestType.TEST_TYPE_READ,
DEFAULT_NR_BYTES, DEFAULT_NR_FILES);
}

@Test (timeout = 10000)
public void testSequentialReadRandom() throws Exception {
FileSystem fs = cluster.getFileSystem();
bench.getConf().setLong("test.io.skip.size", 0);
bench.sequentialTest(fs, TestType.TEST_TYPE_READ_RANDOM,
DEFAULT_NR_BYTES, DEFAULT_NR_FILES);
}

@Test (timeout = 10000)
public void testSequentialAppend() throws Exception {
FileSystem fs = cluster.getFileSystem();
bench.getConf().setLong("test.io.skip.size", 0);
bench.sequentialTest(fs, TestType.TEST_TYPE_READ_RANDOM,
DEFAULT_NR_BYTES, DEFAULT_NR_FILES);
}

@Test (timeout = 10000)
public void testSequentialReadBackward() throws Exception {
FileSystem fs = cluster.getFileSystem();
bench.getConf().setLong("test.io.skip.size", -DEFAULT_BUFFER_SIZE);
bench.sequentialTest(fs, TestType.TEST_TYPE_READ_RANDOM,
DEFAULT_NR_BYTES, DEFAULT_NR_FILES);
}

@Test (timeout = 10000)
public void testSequentialReadSkip() throws Exception {
FileSystem fs = cluster.getFileSystem();
bench.sequentialTest(fs, TestType.TEST_TYPE_APPEND,
DEFAULT_NR_BYTES, DEFAULT_NR_FILES);
}

@Test(timeout = 60000)
public void testSequentialTruncate() throws Exception {
FileSystem fs = cluster.getFileSystem();
// given DEFAULT_NR_BYTES files to be truncated
bench.sequentialTest(fs, TestType.TEST_TYPE_WRITE,
DEFAULT_NR_BYTES, DEFAULT_NR_FILES);
// test truncate
bench.sequentialTest(fs, TestType.TEST_TYPE_TRUNCATE,
DEFAULT_NR_BYTES, DEFAULT_NR_FILES);
}

@SuppressWarnings("deprecation")
private void createControlFile(FileSystem fs,
long nrBytes, // in bytes
Expand Down Expand Up @@ -718,10 +775,18 @@ private void sequentialTest(FileSystem fs,
default:
return;
}
for(int i=0; i < nrFiles; i++)
ioer.doIO(Reporter.NULL,
BASE_FILE_NAME+Integer.toString(i),
fileSize);
for (int i = 0; i < nrFiles; i++) {
ioer.configure(new JobConf(config, TestDFSIO.class));
String fileName = getFileName(i);
ioer.stream = ioer.getIOStream(fileName);
try {
ioer.doIO(Reporter.NULL, fileName, fileSize);
} finally {
if (ioer.stream != null) {
ioer.stream.close();
}
}
}
}

public static void main(String[] args) {
Expand Down