HADOOP-17344. Harmonize guava version and shade guava in yarn-csi.

[aajisaka]

JIRA: https://issues.apache.org/jira/browse/HADOOP-17344

• Use hadoop-shaded-guava
• Remove skip replace-guava setting from yarn-csi pom.xml

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 5s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 35s		trunk passed
+1 💚	compile	0m 34s		trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚	checkstyle	0m 23s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	shadedclient	15m 52s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 32s		trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚	javadoc	0m 26s		trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+0 🆗	spotbugs	1m 1s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 58s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 27s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚	javac	0m 26s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚	javac	0m 23s		the patch passed
+1 💚	checkstyle	0m 13s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
+1 💚	shadedclient	14m 29s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 24s		the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1
+1 💚	javadoc	0m 23s		the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
+1 💚	findbugs	1m 2s		the patch passed
			_ Other Tests _
+1 💚	unit	0m 37s		hadoop-yarn-csi in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		75m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2434/1/artifact/out/Dockerfile
GITHUB PR	#2434
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname	Linux 05019d578850 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 3067a25
Default Java	Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu1.18.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2434/1/testReport/
Max. process+thread count	399 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2434/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.1.3
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[ayushtkn]

Thanx @aajisaka for taking this up.
The changes LGTM. Just one doubt, If you have any context can you help me with why actually yarn-csi, was maintaining a separate guava? I think it has its own separate protobuf version as well. Just to be sure we don't land up breaking any use-case, else things are pretty good here

[aajisaka]

Thanks @ayushtkn for your review.

When the module was created by https://issues.apache.org/jira/browse/YARN-8873, grpc was 1.15.1. I suppose the guava version is maintained separately because grpc 1.15.1 has guava 20.0 dependency (https://github.com/grpc/grpc-java/blob/v1.15.1/build.gradle#L114). Now grpc has been upgraded to 1.26.0 to support ARM (https://issues.apache.org/jira/browse/YARN-10042) and the guava version is 28.1-android (https://github.com/grpc/grpc-java/blob/v1.26.0/build.gradle#L48), so I think we can change the guava version from 20.0 to 27.0-jre.

cc: @yangwwei @sunilgovind for more context

[jojochuang]

LGTM. Same with Ayush. Would be great to get thoughts from Weiwei and Sunil. But given that the APIs are compatible, I think we can go ahead commit this.

[aajisaka]

Merged. Thank you @ayushtkn and @jojochuang