-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-15836. RBF: Fix contract tests after HADOOP-13327 #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aajisaka for the fix! Run into this while working on HDFS-15423.
Thank you @fengnanli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx @aajisaka for the fix.
+1
Merged. Thank you @ayushtkn |
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit 2b3c5b1)
doesn't webhdfs support any of the hflush stuff? So it's not 1:1 consistent with HDFS? |
Yes, it doesn't. There is no documentation for hflush or hsync: https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/WebHDFS.html |
I'm sorry. I thought I'd tested everything, at least through the IDE, but was wrong. The new test really tries to determine what supports hflush/hsync and what just pretends to by not raising an exception in hflush() but which doesn't actually update the output. Apparently the HBase team care about durable storage of their WAL. I've given them the probes, the validation and the ability to use a RAID-5 local FS as the WAL destination |
JIRA: https://issues.apache.org/jira/browse/HDFS-15836
Fix the following tests: