HDFS-16245.Record the number of INodeDirectory when loading the FSImage file. #3512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianghuazhu
force-pushed
the
HDFS-16245
branch
from
dc8fac6 to
e1d453e
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
In jenkins, there are some exceptions, such as: @sodonnell, I remember you have some experience in loading FsImage, can you help review this pr. |
sodonnel
reviewed
Oct 4, 2021
| INodeDirectory p = dir.getInode(e.getParent()).asDirectory(); | ||
| for (long id : e.getChildrenList()) { | ||
| INode child = dir.getInode(id); | ||
| if (child.isDirectory()) { |
Contributor
There was a problem hiding this comment.
We are only incrementing here if its a directory. The inode table / section contains an entry for every file and directory in the system.
The the directory section is what links them all together into the parent child relationship, so it should contain about the same number of entries as inodes.
I am not sure if it makes sense to just count the directories here, as we have already counted them in the inode section.
Why do you want to count just directories? Would it make more sense to count each entry and child entry to give an idea of the number of entries processed by each parallel section?
Contributor
Author
There was a problem hiding this comment.
Thanks @sodonnel for the comment and review.
When loading FsImage, we have recorded the number of all inodes (including INodeFile and INodeDirectory) in the log.
For example, here is the specific record information:
2021-09-30 19:12:55,034 [15609]-INFO [main:FSImageFormatPBINode$Loader@409]-Loading xxxx INodes.
Yes, this is good. We can know the data of the loaded inode, but this is a sum. But we can't know how many INodeFiles or how many INodeDirectory are loaded, if we can know how many INodeFiles are loaded, similarly, we can know how many INodeDirectory is loaded. This will help us find the cause of the problem when there is an exception.
Regarding the reason for dealing with INodeDirectory here. What I want to show is that in many cases, the number of files created will be more than the number of directories created. Therefore, it may use less time when calculating INodeDirectory.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When loading the FSImage file, record the number of loaded INodeDirectory.
Details: HDFS-16245
How was this patch tested?
When the FSImage file is loaded, we need to compare the number of INodeDirectory that has been loaded.