YARN-10760. Number of allocated OPPORTUNISTIC containers can dip below 0 #3642

afchung · 2021-11-10T16:21:34Z

Description of PR

Checks that we do not release containers that do not exist
Checks that we increment recovered allocated OPPORTUNISTIC containers on
RM restart
Adds corresponding test

How was this patch tested?

Unit test added
Deployment to production environment

* Checks that we do not release containers that do not exist * Checks that we increment recovered allocated OPPORTUNISTIC containers on RM restart * Adds corresponding test

...main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java

.../apache/hadoop/yarn/server/resourcemanager/TestOpportunisticContainerAllocatorAMService.java

goiri · 2021-11-10T18:28:23Z

.../apache/hadoop/yarn/server/resourcemanager/TestOpportunisticContainerAllocatorAMService.java

+
+    OpportunisticSchedulerMetrics metrics =
+        OpportunisticSchedulerMetrics.getMetrics();
+    Assert.assertEquals(1,


We probably want to assert before this too with a 0 and maybe one of the cases where we do not increment.
I have the feeling this test passes even without the code changes.

Makes sense. This helped me find that while the test passes when run on its own, it fails when run with the rest of the tests in the class since the metrics were not re-initialized between tests.

afchung · 2021-11-10T19:33:18Z

@goiri thanks for the review! Pushed a new commit to address your comments, please have another look.

hadoop-yetus · 2021-11-10T19:54:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 57s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	37m 9s		trunk passed
+1 💚	compile	1m 18s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	1m 4s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 49s		trunk passed
+1 💚	mvnsite	1m 7s		trunk passed
+1 💚	javadoc	0m 54s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 46s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	2m 18s		trunk passed
+1 💚	shadedclient	24m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 1s		the patch passed
+1 💚	compile	1m 12s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	1m 12s		the patch passed
+1 💚	compile	0m 56s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 56s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 42s		the patch passed
+1 💚	mvnsite	1m 3s		the patch passed
+1 💚	javadoc	0m 49s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 40s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	2m 22s		the patch passed
+1 💚	shadedclient	24m 30s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	106m 54s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		210m 45s

Reason	Tests
Failed junit tests	hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3642/1/artifact/out/Dockerfile
GITHUB PR	#3642
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 3a258a2f77b1 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bb48aa5`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3642/1/testReport/
Max. process+thread count	937 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3642/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-11-10T23:31:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 6s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	13m 2s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 51s		trunk passed
+1 💚	compile	4m 48s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	3m 45s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 17s		trunk passed
+1 💚	mvnsite	1m 51s		trunk passed
+1 💚	javadoc	1m 31s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 22s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 48s		trunk passed
+1 💚	shadedclient	24m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 39s		the patch passed
+1 💚	compile	4m 37s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	4m 37s		the patch passed
+1 💚	compile	3m 40s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	3m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 11s		the patch passed
+1 💚	mvnsite	1m 40s		the patch passed
+1 💚	javadoc	1m 19s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 10s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 59s		the patch passed
+1 💚	shadedclient	24m 37s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 57s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	106m 18s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		237m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3642/2/artifact/out/Dockerfile
GITHUB PR	#3642
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux d42faf61da34 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4c1aa91`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3642/2/testReport/
Max. process+thread count	938 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3642/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

…w 0 (apache#3642)

YARN-10760. Number of allocated OPPORTUNISTIC containers can dip below 0

bb48aa5

* Checks that we do not release containers that do not exist * Checks that we increment recovered allocated OPPORTUNISTIC containers on RM restart * Adds corresponding test

goiri reviewed Nov 10, 2021

View reviewed changes

Address review comments. Add more tests and reset metrics between tests.

4c1aa91

goiri approved these changes Nov 15, 2021

View reviewed changes

goiri merged commit d3f0b7e into apache:trunk Nov 23, 2021

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

YARN-10760. Number of allocated OPPORTUNISTIC containers can dip belo…

7217187

…w 0 (apache#3642)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-10760. Number of allocated OPPORTUNISTIC containers can dip below 0 #3642

YARN-10760. Number of allocated OPPORTUNISTIC containers can dip below 0 #3642

afchung commented Nov 10, 2021

Uh oh!

Uh oh!

Uh oh!

goiri Nov 10, 2021

Uh oh!

afchung Nov 10, 2021 •

edited

Loading

Uh oh!

afchung commented Nov 10, 2021

Uh oh!

hadoop-yetus commented Nov 10, 2021

Uh oh!

hadoop-yetus commented Nov 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YARN-10760. Number of allocated OPPORTUNISTIC containers can dip below 0 #3642

YARN-10760. Number of allocated OPPORTUNISTIC containers can dip below 0 #3642

Conversation

afchung commented Nov 10, 2021

Description of PR

How was this patch tested?

Uh oh!

Uh oh!

Uh oh!

goiri Nov 10, 2021

Choose a reason for hiding this comment

Uh oh!

afchung Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

afchung commented Nov 10, 2021

Uh oh!

hadoop-yetus commented Nov 10, 2021

Uh oh!

hadoop-yetus commented Nov 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

afchung Nov 10, 2021 •

edited

Loading