-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-18016. Make certain methods LimitedPrivate in S3AUtils.java #3685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mukund-thakur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Remove "proxy support from the commit message"
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java
Outdated
Show resolved
Hide resolved
mukund-thakur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
|
Yetus failed. I don't how to retrigger. |
|
just rebase and resubmit. |
2e2208b to
28d9a76
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Merging as yetus if only failing for no new tests and new tests are not required for this PR. |
…pache#3685) Contributed By: Mehakmeet Singh
No tests included since it's just an annotation change.
Ran the test suite after compiling successfully.
Region:
ap-south-1Tests:
[WARNING] Tests run: 588, Failures: 0, Errors: 0, Skipped: 5[ERROR] Tests run: 1471, Failures: 0, Errors: 2, Skipped: 466(my bucket specific failures, ignore)[ERROR] Tests run: 151, Failures: 1, Errors: 1, Skipped: 28(my bucket specific failures, ignore)