Skip to content

Conversation

@GuoPhilipse
Copy link
Member

fs.s3a.committer.magic.enabled was set to true by default after HADOOP-17483, we can improve the doc

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@steveloughran
Copy link
Contributor

merging to trunk; will pull into 3.3 once I've got that building locally

@steveloughran
Copy link
Contributor

oh, before I merge, what do you want as your name in the "contributed by" line?

@GuoPhilipse
Copy link
Member Author

GuoPhilipse commented Nov 25, 2021

oh, before I merge, what do you want as your name in the "contributed by" line?

Thanks @steveloughran for your review, you can call me guophilipse as the jira username :)

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 12s trunk passed
+1 💚 mvnsite 0m 50s trunk passed
+1 💚 shadedclient 54m 56s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 37s the patch passed
+1 💚 shadedclient 22m 17s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
80m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3723/1/artifact/out/Dockerfile
GITHUB PR #3723
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux 23c7a1bbe834 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / eeada77
Max. process+thread count 671 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3723/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran merged commit c65c87f into apache:trunk Nov 29, 2021
@GuoPhilipse
Copy link
Member Author

@steveloughran need i now close the JIRA or will you operate?

asfgit pushed a commit that referenced this pull request Dec 3, 2021
Contributed by guophilipse

Change-Id: If915623c76619dd3d3b3bdf989688fa13e56fec1
@steveloughran
Copy link
Contributor

I've closed it and pulled it into 3.3.3; for some reason I can't assign it to you even though I've tried to add you to the contributors group. Sorry. I'm having a hard time with JIRA right now.

@GuoPhilipse
Copy link
Member Author

I've closed it and pulled it into 3.3.3; for some reason I can't assign it to you even though I've tried to add you to the contributors group. Sorry. I'm having a hard time with JIRA right now.

Thanks @steveloughran for your merge, i just reopened the JIRA trying to assign to myself, it seems still not working with me , anyway ,it does not matter ,Could you help resolve the JIRA again ?

@steveloughran
Copy link
Contributor

i've broken a collar bone and can only type by setting my keyboard up to have left hand qwerty keys on the right when i press ALT. this and dictation is ok for email, slack and JIRA messages-but not any complex JIRA work, eg autocompleting fields, admin etc.

ask again in january when my left hand should be working again.I'm going off-line now until then anyway.

@GuoPhilipse GuoPhilipse deleted the improvedocincommitters branch December 11, 2021 13:15
@GuoPhilipse
Copy link
Member Author

I‘am so sorry to hear that, Thanks for your notice me the info . really hope you are getting well soon.

sunchao pushed a commit that referenced this pull request Jan 4, 2022
Contributed by guophilipse

Change-Id: If915623c76619dd3d3b3bdf989688fa13e56fec1
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants