-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-18026. Fix default value of Magic committer #3723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18026. Fix default value of Magic committer #3723
Conversation
steveloughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
merging to trunk; will pull into 3.3 once I've got that building locally |
|
oh, before I merge, what do you want as your name in the "contributed by" line? |
Thanks @steveloughran for your review, you can call me |
|
🎊 +1 overall
This message was automatically generated. |
|
@steveloughran need i now close the JIRA or will you operate? |
Contributed by guophilipse Change-Id: If915623c76619dd3d3b3bdf989688fa13e56fec1
|
I've closed it and pulled it into 3.3.3; for some reason I can't assign it to you even though I've tried to add you to the contributors group. Sorry. I'm having a hard time with JIRA right now. |
Thanks @steveloughran for your merge, i just reopened the JIRA trying to assign to myself, it seems still not working with me , anyway ,it does not matter ,Could you help resolve the JIRA again ? |
|
i've broken a collar bone and can only type by setting my keyboard up to have left hand qwerty keys on the right when i press ALT. this and dictation is ok for email, slack and JIRA messages-but not any complex JIRA work, eg autocompleting fields, admin etc. ask again in january when my left hand should be working again.I'm going off-line now until then anyway. |
|
I‘am so sorry to hear that, Thanks for your notice me the info . really hope you are getting well soon. |
Contributed by guophilipse Change-Id: If915623c76619dd3d3b3bdf989688fa13e56fec1
Contributed by guophilipse
fs.s3a.committer.magic.enabledwas set to true by default after HADOOP-17483, we can improve the doc