HDFS-11107.TestStartup#testStorageBlockContentsStaleAfterNNRestart fails intermittently.

[jianghuazhu]

Description of PR

Fix TestStartup#testStorageBlockContentsStaleAfterNNRestart test failure.

How was this patch tested?

UT.

[jianghuazhu]

Before repairing, it usually takes more than 60s to test once.
For example, here is the time consuming I tested:

1. Time-consuming: 77254 ms
2. Time-consuming: 77525 ms
3. Time-consuming: 77083 ms
4. Time-consuming: 76345 ms
5. Time-consuming: 76616 ms

I found 2 locations to be very time consuming.

1. Use socket to get host
   `
   org.junit.runners.model.TestTimedOutException: test timed out after 60000 milliseconds

   at java.net.InetAddress.getLocalHost(InetAddress.java:1487)
   at sun.management.VMManagementImpl.getVmId(VMManagementImpl.java:140)
   `

2. The connection related to the host.
   `
   2022-01-05 22:24:57,012 [BP-787407874-10.242.143.133-1641392642386 heartbeating to localhost/127.0.0.1:49461] INFO ipc.Client (Client.java:handleConnectionFailure(1010)) - Retrying connect to server: localhost/127.0.0.1:49461. Already tried 0 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1000 MILLISECONDS)
   2022-01-05 22:24:58,016 [BP-787407874-10.242.143.133-1641392642386 heartbeating to localhost/127.0.0.1:49461] INFO ipc.Client (Client.java:handleConnectionFailure(1010)) - Retrying connect to server: localhost/127.0.0.1:49461. Already tried 1 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1000 MILLISECONDS)

`

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 42s		trunk passed
+1 💚	compile	1m 30s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	1m 21s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 1s		trunk passed
+1 💚	mvnsite	1m 29s		trunk passed
+1 💚	javadoc	1m 0s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 31s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 21s		trunk passed
+1 💚	shadedclient	22m 35s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 18s		the patch passed
+1 💚	compile	1m 19s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	1m 19s		the patch passed
+1 💚	compile	1m 11s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	1m 11s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 51s		the patch passed
+1 💚	mvnsite	1m 17s		the patch passed
+1 💚	javadoc	0m 55s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	1m 27s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	3m 30s		the patch passed
+1 💚	shadedclient	23m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	228m 14s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		330m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3862/1/artifact/out/Dockerfile
GITHUB PR	#3862
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 13c72faf5be9 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 67c64a0
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3862/1/testReport/
Max. process+thread count	3027 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3862/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[jianghuazhu]

Can you help review this pr, @ayushtkn @tomscut .
Thank you very much.

[ayushtkn]

The error message in the description is an Assertion Error. Not a timeout error.

Error Message

expected:<0> but was:<2>
Stacktrace

java.lang.AssertionError: expected:<0> but was:<2>

[jianghuazhu]

Thanks @ayushtkn for the pointers, I'll keep trying to fix this.

[github-actions]

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.