Skip to content

HDFS-16438. Avoid holding read locks for a long time when scanDatanodeStorage #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

HDFS-16438. Avoid holding read locks for a long time when scanDatanodeStorage #3928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8acbfe
HDFS-16438. Avoid holding read locks for a long time when scanDatanod…
tomscut Jan 25, 2022
95535ac
moving the replicated check outside of the lock
tomscut Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions .../main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminBackoffMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,24 +652,27 @@ private void scanDatanodeStorage(DatanodeDescriptor dn,
Iterator<BlockInfo> it = s.getBlockIterator();
while (it.hasNext()) {
BlockInfo b = it.next();
if (!initialScan || dn.isEnteringMaintenance()) {
// this is a rescan, so most blocks should be replicated now,
// or this node is going into maintenance. On a healthy
// cluster using racks or upgrade domain, a node should be
// able to go into maintenance without replicating many blocks
// so we will check them immediately.
if (!isBlockReplicatedOk(dn, b, false, null)) {
blockList.put(b, null);
}
} else {
blockList.put(b, null);
}
blockList.put(b, null);
numBlocksChecked++;
}
} finally {
namesystem.readUnlock();
}
}
if (!initialScan || dn.isEnteringMaintenance()) {
// this is a rescan, so most blocks should be replicated now,
// or this node is going into maintenance. On a healthy
// cluster using racks or upgrade domain, a node should be
// able to go into maintenance without replicating many blocks
// so we will check them immediately.
Iterator<BlockInfo> iterator = blockList.keySet().iterator();
while(iterator.hasNext()) {
BlockInfo b = iterator.next();
if (isBlockReplicatedOk(dn, b, false, null)) {
iterator.remove();
}
}
}
}

/**
Expand Down