-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11072. Cannot display hadoop-st.png when using reverse proxy and applying APPLICATION_WEB_PROXY_BASE #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
e1a3576 to
de29777
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Samrat002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the bug report and pr .
apart from some variable naming and extra comments the patch LGTM .
can you please make changes !
| Class<?> processEnvironmentClass = Class.forName("java.lang.ProcessEnvironment"); | ||
| String fieldname = "theEnvironment"; | ||
| Field theEnvironmentField = processEnvironmentClass.getDeclaredField(fieldname); | ||
| // reset environment accessibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this comment .
it is well understood from code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. Thank you for letting me know!
| } | ||
| fieldname = "theCaseInsensitiveEnvironment"; | ||
| Field theCaseInsensitiveEnvField = processEnvironmentClass.getDeclaredField(fieldname); | ||
| // reset environment accessibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this comment .
it is well understood from code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
|
🎊 +1 overall
This message was automatically generated. |
Samrat002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ,
Thank you bensonlin, for the changes
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Description of PR
Scenario:
When I want to use reverse proxy and apply APPLICATION_WEB_PROXY_BASE to change the base path, it can not find the hadoop-st.png.
(file: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/HeaderBlock.java)
Issues:
The image path should be /base_path/static/hadoop-st.png.
JIRA YARN-11072
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?