Skip to content

HDFS-16454:fix inconsistent comments in DataNode #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HDFS-16454:fix inconsistent comments in DataNode #3982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...fs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,14 +2227,14 @@ public void shutdown() {
// wait reconfiguration thread, if any, to exit
shutdownReconfigurationTask();

LOG.info("Waiting up to 30 seconds for transfer threads to complete");
LOG.info("Waiting up to 15 seconds for transfer threads to complete");
Copy link
Contributor

@cndaimin cndaimin Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

executorService.awaitTermination(timeout, unit) will be possibly invoked 2 times in HadoopExecutors#shutdown. The time value in log looks ok.

HadoopExecutors.shutdown(this.xferService, LOG, 15L, TimeUnit.SECONDS);

// wait for all data receiver threads to exit
if (this.threadGroup != null) {
int sleepMs = 2;
while (true) {
// When shutting down for restart, wait 2.5 seconds before forcing
// When shutting down for restart, wait 1.0 seconds before forcing
// termination of receiver threads.
if (!this.shutdownForUpgrade ||
(this.shutdownForUpgrade && (Time.monotonicNow() - timeNotified
Expand Down