HDFS-16514. Reduce the failover sleep time if multiple namenode are c… #4088

liubingxing · 2022-03-21T12:06:00Z

JIRA: HDFS-16514
Recently, we used the [Standby Read] feature in our test cluster, and deployed 4 namenode as follow:
node1 -> active nn
node2 -> standby nn
node3 -> observer nn
node3 -> observer nn

If we set ’dfs.client.failover.random.order=true‘, the client may failover twice and wait a long time to send msync to active namenode.

I think we can reduce the sleep time of the first several failover based on the number of namenode.
For example, if 4 namenode are configured, the sleep time of first three failover operations is set to zero.

hadoop-yetus · 2022-03-21T14:20:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	12m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 28s		Maven dependency ordering for branch
+1 💚	mvninstall	29m 14s		trunk passed
+1 💚	compile	31m 9s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
-1 ❌	compile	21m 46s	/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-0 ⚠️	checkstyle	0m 39s	/buildtool-branch-checkstyle-root.txt	The patch fails to run checkstyle in root
-1 ❌	mvnsite	0m 38s	/branch-mvnsite-hadoop-common-project_hadoop-common.txt	hadoop-common in trunk failed.
-1 ❌	mvnsite	0m 39s	/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in trunk failed.
-1 ❌	javadoc	0m 39s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-common in trunk failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javadoc	0m 39s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javadoc	0m 37s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	hadoop-common in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javadoc	0m 38s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	hadoop-hdfs-client in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	spotbugs	0m 38s	/branch-spotbugs-hadoop-common-project_hadoop-common.txt	hadoop-common in trunk failed.
-1 ❌	spotbugs	0m 39s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in trunk failed.
+1 💚	shadedclient	7m 24s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 22s	/patch-mvninstall-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	mvninstall	0m 23s	/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in the patch failed.
-1 ❌	compile	0m 22s	/patch-compile-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	root in the patch failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javac	0m 22s	/patch-compile-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	root in the patch failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	compile	0m 23s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javac	0m 23s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 20s	/buildtool-patch-checkstyle-root.txt	The patch fails to run checkstyle in root
-1 ❌	mvnsite	0m 22s	/patch-mvnsite-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	mvnsite	0m 23s	/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in the patch failed.
-1 ❌	javadoc	0m 22s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-common in the patch failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javadoc	0m 24s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javadoc	0m 23s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	hadoop-common in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javadoc	0m 23s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	hadoop-hdfs-client in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	spotbugs	0m 49s	/patch-spotbugs-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	spotbugs	0m 16s	/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in the patch failed.
+1 💚	shadedclient	6m 34s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	6m 55s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
-1 ❌	unit	0m 46s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in the patch failed.
-1 ❌	asflicense	0m 29s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		133m 16s

Reason	Tests
Failed junit tests	hadoop.fs.TestFileSystemCaching
	hadoop.service.launcher.TestServiceLauncherCreationFailures

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/1/artifact/out/Dockerfile
GITHUB PR	#4088
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 44b444b3b14b 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 2fd415a9a75c5037ba1e94fa8dd889d8992507b3
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/1/testReport/
Max. process+thread count	247 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-03-22T07:24:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for branch
-1 ❌	mvninstall	0m 25s	/branch-mvninstall-root.txt	root in trunk failed.
-1 ❌	compile	0m 25s	/branch-compile-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	root in trunk failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	compile	0m 24s	/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-0 ⚠️	checkstyle	0m 22s	/buildtool-branch-checkstyle-root.txt	The patch fails to run checkstyle in root
-1 ❌	mvnsite	0m 25s	/branch-mvnsite-hadoop-common-project_hadoop-common.txt	hadoop-common in trunk failed.
-1 ❌	mvnsite	0m 23s	/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in trunk failed.
-1 ❌	javadoc	0m 23s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-common in trunk failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javadoc	0m 23s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javadoc	0m 23s	/branch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	hadoop-common in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javadoc	0m 23s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	hadoop-hdfs-client in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	spotbugs	0m 23s	/branch-spotbugs-hadoop-common-project_hadoop-common.txt	hadoop-common in trunk failed.
-1 ❌	spotbugs	0m 24s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in trunk failed.
+1 💚	shadedclient	4m 20s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
-1 ❌	mvninstall	0m 24s	/patch-mvninstall-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	mvninstall	0m 24s	/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in the patch failed.
-1 ❌	compile	0m 24s	/patch-compile-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	root in the patch failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javac	0m 24s	/patch-compile-root-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	root in the patch failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	compile	0m 24s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javac	0m 24s	/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 22s	/buildtool-patch-checkstyle-root.txt	The patch fails to run checkstyle in root
-1 ❌	mvnsite	0m 24s	/patch-mvnsite-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	mvnsite	0m 24s	/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in the patch failed.
-1 ❌	javadoc	0m 24s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-common in the patch failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javadoc	0m 24s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javadoc	0m 24s	/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	hadoop-common in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	javadoc	0m 24s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt	hadoop-hdfs-client in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 ❌	spotbugs	0m 24s	/patch-spotbugs-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	spotbugs	0m 24s	/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in the patch failed.
+1 💚	shadedclient	6m 13s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 24s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch failed.
-1 ❌	unit	0m 24s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt	hadoop-hdfs-client in the patch failed.
+0 🆗	asflicense	0m 24s		ASF License check generated no output?
		17m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/2/artifact/out/Dockerfile
GITHUB PR	#4088
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 5e35c499cd9d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 74c7ea3bc5a31d78a5082ee73b32199c27508776
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/2/testReport/
Max. process+thread count	32 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-03-23T08:13:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 43s		Maven dependency ordering for branch
+1 💚	mvninstall	22m 56s		trunk passed
+1 💚	compile	22m 50s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	20m 0s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	3m 38s		trunk passed
+1 💚	mvnsite	2m 56s		trunk passed
+1 💚	javadoc	2m 12s		trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 43s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	5m 11s		trunk passed
+1 💚	shadedclient	25m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 53s		the patch passed
+1 💚	compile	23m 32s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	23m 32s		the patch passed
+1 💚	compile	20m 42s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 37s	/results-checkstyle-root.txt	root: The patch generated 1 new + 45 unchanged - 0 fixed = 46 total (was 45)
+1 💚	mvnsite	2m 49s		the patch passed
+1 💚	javadoc	1m 54s		the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	2m 29s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	5m 43s		the patch passed
+1 💚	shadedclient	25m 54s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 10s		hadoop-common in the patch passed.
+1 💚	unit	2m 48s		hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	0m 58s		The patch does not generate ASF License warnings.
		233m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/3/artifact/out/Dockerfile
GITHUB PR	#4088
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux e7152761be30 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 140dad88d65a6de47eda8e784d35f545922e7cce
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/3/testReport/
Max. process+thread count	1316 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

cndaimin · 2022-04-13T10:42:03Z

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java

The comments here looks need to be updated too.

@cndaimin I updated the code. Please take a look.

liubingxing · 2022-04-15T04:20:01Z

@tasanuma Please take a look at this. Thanks a lot.

hadoop-yetus · 2022-04-15T08:12:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	16m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 17s		trunk passed
+1 💚	compile	22m 54s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	20m 6s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	3m 45s		trunk passed
+1 💚	mvnsite	2m 55s		trunk passed
+1 💚	javadoc	2m 15s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 40s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	5m 26s		trunk passed
+1 💚	shadedclient	22m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 47s		the patch passed
+1 💚	compile	22m 9s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	22m 9s		the patch passed
+1 💚	compile	20m 15s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 15s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 35s	/results-checkstyle-root.txt	root: The patch generated 2 new + 45 unchanged - 0 fixed = 47 total (was 45)
+1 💚	mvnsite	2m 58s		the patch passed
+1 💚	javadoc	2m 9s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 40s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	5m 50s		the patch passed
+1 💚	shadedclient	22m 58s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 54s		hadoop-common in the patch passed.
+1 💚	unit	2m 41s		hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	1m 0s		The patch does not generate ASF License warnings.
		232m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/4/artifact/out/Dockerfile
GITHUB PR	#4088
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 4d32bdb55e3e 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 4cce98a713ad900b14ebb5f6855e76cbb1519437
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/4/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

…onfigured

hadoop-yetus · 2022-04-15T12:39:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 52s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 16s		trunk passed
+1 💚	compile	22m 50s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	19m 59s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	3m 51s		trunk passed
+1 💚	mvnsite	2m 54s		trunk passed
+1 💚	javadoc	2m 14s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 39s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	5m 24s		trunk passed
+1 💚	shadedclient	22m 55s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 46s		the patch passed
+1 💚	compile	22m 17s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	22m 17s		the patch passed
+1 💚	compile	20m 8s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 8s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 37s	/results-checkstyle-root.txt	root: The patch generated 2 new + 45 unchanged - 0 fixed = 47 total (was 45)
+1 💚	mvnsite	2m 53s		the patch passed
+1 💚	javadoc	2m 8s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 39s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	5m 34s		the patch passed
+1 💚	shadedclient	22m 51s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 47s		hadoop-common in the patch passed.
+1 💚	unit	2m 39s		hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	1m 1s		The patch does not generate ASF License warnings.
		231m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/5/artifact/out/Dockerfile
GITHUB PR	#4088
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 72463f9f61d9 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d37473e`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/5/testReport/
Max. process+thread count	1258 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-10-22T05:08:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	15m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	9m 54s		Maven dependency ordering for branch
+1 💚	mvninstall	32m 47s		trunk passed
+1 💚	compile	16m 59s		trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	compile	17m 41s		trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚	checkstyle	3m 4s		trunk passed
+1 💚	mvnsite	3m 11s		trunk passed
+1 💚	javadoc	2m 24s		trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 11s		trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
-1 ❌	spotbugs	3m 10s	/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html	hadoop-common-project/hadoop-common in trunk has 448 extant spotbugs warnings.
-1 ❌	spotbugs	3m 47s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html	hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2801 extant spotbugs warnings.
+1 💚	shadedclient	32m 13s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 0s		the patch passed
+1 💚	compile	14m 35s		the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	javac	14m 35s		the patch passed
+1 💚	compile	15m 27s		the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚	javac	15m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 10s	/results-checkstyle-root.txt	root: The patch generated 2 new + 42 unchanged - 0 fixed = 44 total (was 42)
+1 💚	mvnsite	3m 4s		the patch passed
-1 ❌	javadoc	1m 19s	/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt	hadoop-common-project_hadoop-common-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04 with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 generated 1 new + 4453 unchanged - 0 fixed = 4454 total (was 4453)
-1 ❌	javadoc	1m 16s	/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt	hadoop-common-project_hadoop-common-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04 with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 generated 1 new + 3737 unchanged - 0 fixed = 3738 total (was 3737)
+1 💚	spotbugs	7m 1s		the patch passed
+1 💚	shadedclient	29m 23s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	22m 18s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	unit	2m 54s		hadoop-hdfs-client in the patch passed.
+1 💚	asflicense	1m 4s		The patch does not generate ASF License warnings.
		249m 24s

Reason	Tests
Failed junit tests	hadoop.security.ssl.TestDelegatingSSLSocketFactory

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/1/artifact/out/Dockerfile
GITHUB PR	#4088
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 350e378c0892 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d37473e`
Default Java	Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/1/testReport/
Max. process+thread count	2439 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4088/1/console
versions	git=2.25.1 maven=3.9.11 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

liubingxing force-pushed the HDFS-16514 branch from 2fd415a to 74c7ea3 Compare March 22, 2022 07:06

liubingxing force-pushed the HDFS-16514 branch from 74c7ea3 to 140dad8 Compare March 23, 2022 04:18

cndaimin reviewed Apr 13, 2022

View reviewed changes

liubingxing force-pushed the HDFS-16514 branch from 140dad8 to 4cce98a Compare April 15, 2022 04:18

HDFS-16514. Reduce the failover sleep time if multiple namenode are c…

d37473e

…onfigured

liubingxing force-pushed the HDFS-16514 branch from 4cce98a to d37473e Compare April 15, 2022 08:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-16514. Reduce the failover sleep time if multiple namenode are c… #4088

HDFS-16514. Reduce the failover sleep time if multiple namenode are c… #4088

liubingxing commented Mar 21, 2022

Uh oh!

hadoop-yetus commented Mar 21, 2022

Uh oh!

hadoop-yetus commented Mar 22, 2022

Uh oh!

hadoop-yetus commented Mar 23, 2022

Uh oh!

cndaimin Apr 13, 2022

Uh oh!

liubingxing Apr 15, 2022

Uh oh!

liubingxing commented Apr 15, 2022

Uh oh!

hadoop-yetus commented Apr 15, 2022

Uh oh!

hadoop-yetus commented Apr 15, 2022

Uh oh!

hadoop-yetus commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDFS-16514. Reduce the failover sleep time if multiple namenode are c… #4088

Are you sure you want to change the base?

HDFS-16514. Reduce the failover sleep time if multiple namenode are c… #4088

Conversation

liubingxing commented Mar 21, 2022

Uh oh!

hadoop-yetus commented Mar 21, 2022

Uh oh!

hadoop-yetus commented Mar 22, 2022

Uh oh!

hadoop-yetus commented Mar 23, 2022

Uh oh!

cndaimin Apr 13, 2022

Choose a reason for hiding this comment

Uh oh!

liubingxing Apr 15, 2022

Choose a reason for hiding this comment

Uh oh!

liubingxing commented Apr 15, 2022

Uh oh!

hadoop-yetus commented Apr 15, 2022

Uh oh!

hadoop-yetus commented Apr 15, 2022

Uh oh!

hadoop-yetus commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants