Skip to content

HADOOP-18362. Solve ZKFailoverController throw ambiguous exception #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

HADOOP-18362. Solve ZKFailoverController throw ambiguous exception #4648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b333ed
add pre-check of cachetimeout
MEILIDEKCL Jul 28, 2022
6fb4e86
Update TestGroupsCaching.java
MEILIDEKCL Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Groups.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,11 @@ public Groups(Configuration conf, final Timer timer) {
CommonConfigurationKeys.
HADOOP_SECURITY_GROUPS_CACHE_BACKGROUND_RELOAD_THREADS_DEFAULT);
parseStaticMapping(conf);

if(cacheTimeout<=0){
throw new IllegalArgumentException(
"hadoop.security.groups.cache.secs should be larger than 0",
new IllegalArgumentException("hadoop.security.groups.cache.secs should be larger than 0"));
}
this.timer = timer;
this.cache = CacheBuilder.newBuilder()
.refreshAfterWrite(cacheTimeout, TimeUnit.MILLISECONDS)
Expand Down
2 changes: 1 addition & 1 deletion ...mon-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestGroupsCaching.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ public static void resetRequestCount() {

@Test
public void testGroupsCaching() throws Exception {
// Disable negative cache.
// Disable zero cache.
conf.setLong(
CommonConfigurationKeys.HADOOP_SECURITY_GROUPS_NEGATIVE_CACHE_SECS, 0);
Groups groups = new Groups(conf);
Expand Down