-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-18419. Don't fail when using -DNoUnitTests #4801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn Build 4 passed as expected, addressing the issue you identified. The multiple builds were required because of out of memory issues on a specific host. I'm not sure why the github status failed (it's still showing the results of build 2) |
|
@snmvaughan if you see I had a PR as well there on the jira along with that comment where I flagged the issue, #4800 |
|
No problem. I missed the other pull request. |
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
There are commands in hadoop.sh that use -Dtest=NoUnitTests. I believe this is intended to replace -DskipTest, by not matching any tests. This causes an issue since the default for surefire.failIfNoSpecifiedTests is true.
Updating those commands to override the default will address the issue.
LICENSE,LICENSE-binary,NOTICE-binaryfiles?