HADOOP-18417. Upgrade to M7 of surefire plugin

[snmvaughan]

Description of PR

This addresses an issue where the plugin's default classpath for executing tests fails to include org.junit.platform.launcher.core.LauncherFactory.

It adds failIfNoSpecifiedTests defaulted to false, as it is breaking the shaded client build and we are a multi module project.
if you run mvn clean test -Dtest=TestDistributedFileSystem this is expected to work

How was this patch tested?

Executed locally to replicate the original failure introduced by upgrading the plugin:

mvn --batch-mode verify -fae --batch-mode -am -pl hadoop-client-modules/hadoop-client-check-invariants -pl hadoop-client-modules/hadoop-client-check-test-invariants -pl hadoop-client-modules/hadoop-client-integration-tests -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true

Running just a specific test across the entire project runs a single test without failing:

mvn clean test -Dtest=TestDistributedFileSystem

Running NoUnitTests across the entire project runs no tests without failing:

maven surefire:test -Dtest=NoUnitTests

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[snmvaughan]

@steveloughran @ayushtkn This addresses the LauncherFactory issue while still allowing -DNoUnitTests to work. I've added a change to the root project as well, so that it functions globally.

[steveloughran]

lgtm; let's see what yetus says

[snmvaughan]

The builds aren't really providing any feedback, and local runs work as expected. The 1st build failed due to what appears to be a memory issue (exit code 137). The 2nd build failed during the 1st precommit-run complaining that the log file wasn't getting updated, but there were no other messages. I've rebased the patch to see if one of the changes since the pull request was started has an impact.

[ayushtkn]

I am not sure what's happening here with the build, but the unit test results seems incomplete here:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4807/3/artifact/out/patch-unit-root.txt

I am not sure, might be some temporary issue, else need to see what got recently changed around the hadoop script or the Jenkins file, I have retriggered the build for now, if it still doesn't work try a rebase and push, if no luck let me know I will try to help and find some solution to unblock you. :-)

[steveloughran]

do a rebase and push out to see what happens again...

[snmvaughan]

Rebased to determine current state.

[steveloughran]

what's the state of this patch?

[ayushtkn]

Triggered the build and it failed with

script returned exit code 137

Not sure what it is, but I don't think it is something Jenkins related now, because this failed 6 times now, it can't be a coincidence

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	patch	0m 14s		#4807 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem	Report/Notes
GITHUB PR	#4807
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4807/7/console
versions	git=2.34.1
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[github-actions]

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.