BPServiceActor to provide new thread to handle IBR #4820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Aug 29, 2022
| any(DatanodeRegistration.class), | ||
| anyString(), | ||
| any(StorageReceivedDeletedBlocks[].class)); | ||
| int retries = 0; |
| dnConf.outliersReportIntervalMs); | ||
| // get the value of maxDataLength. | ||
| sendIBRLock = new Object(); | ||
| ibrExecutorService = Executors.newSingleThreadExecutor( |
Member
There was a problem hiding this comment.
ThreadFactory threadFactory = new ThreadFactoryBuilder()
.setDaemon(true)
.setNameFormat("IBR-executor-%d")
.build()
ibrExecutorService = Executors.newSingleThreadExecutor(threadFactory);
| return Time.monotonicNow(); | ||
| } | ||
| } | ||
|
|
| try { | ||
| meta = FsDatasetUtil.getMetaFile(getBlockFile(b), b.getGenerationStamp()); | ||
| } catch (IOException e) { | ||
| throw new FileNotFoundException("BlockId " + b.getBlockName() + " is not valid."); |
Member
There was a problem hiding this comment.
How did the old exception look like?
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BPServiceActor to provide new thread to handle IBR