Skip to content

HADOOP-18491. Fixed negative data and throughput values in an output of class RawErasureCoderBenchmark #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HADOOP-18491. Fixed negative data and throughput values in an output of class RawErasureCoderBenchmark #5000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...mon/src/test/java/org/apache/hadoop/io/erasurecode/rawcoder/RawErasureCoderBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ private static class BenchData {
private ByteBuffer[] decodeInputs = new ByteBuffer[NUM_ALL_UNITS];

public static void configure(int dataSizeMB, int chunkSizeKB) {
Preconditions.checkArgument(dataSizeMB > 0);
chunkSize = chunkSizeKB * 1024;
// buffer size needs to be a multiple of (numDataUnits * chunkSize)
int round = (int) Math.round(
Expand Down
9 changes: 9 additions & 0 deletions ...src/test/java/org/apache/hadoop/io/erasurecode/rawcoder/TestRawErasureCoderBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.hadoop.io.erasurecode.rawcoder;

import org.apache.hadoop.io.erasurecode.ErasureCodeNative;
import org.junit.Assert;
import org.junit.Assume;
import org.junit.Test;

Expand All @@ -33,6 +34,14 @@ public void testDummyCoder() throws Exception {
RawErasureCoderBenchmark.CODER.DUMMY_CODER, 2, 100, 1024);
RawErasureCoderBenchmark.performBench("decode",
RawErasureCoderBenchmark.CODER.DUMMY_CODER, 5, 150, 100);

try {
RawErasureCoderBenchmark.performBench("decode",
RawErasureCoderBenchmark.CODER.DUMMY_CODER, 5, -150, 100);
Assert.fail("should have thrown an IllegalArgumentException");
} catch (IllegalArgumentException e) {
// intentionally swallow exception
}
}

@Test
Expand Down