HDFS-16867. Exiting Mover due to an exception in MoverMetrics.create #5203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@Jing9 Hello, could you please help review it |
|
💔 -1 overall
This message was automatically generated. |
Jing9
reviewed
Dec 19, 2022
Contributor
Jing9
left a comment
Jing9
left a comment
There was a problem hiding this comment.
Thanks a lot for reporting the issue and providing the fix! Some comments regarding the detailed implementation for the fix.
| private final Path idPath; | ||
| private OutputStream out; | ||
| private final List<Path> targetPaths; | ||
| private final MoverMetrics moverMetrics; |
Contributor
There was a problem hiding this comment.
NameNodeConnector will also be used by Balancer, while MoverMetrics is only used by Mover. So not sure if placing MoverMetrics directly in NameNodeConnector is a good way from the semantic perspective.
| BlockStoragePolicySuite.ID_BIT_LENGTH]; | ||
| this.excludedPinnedBlocks = excludedPinnedBlocks; | ||
| this.nnc = nnc; | ||
| this.metrics = MoverMetrics.create(this); |
Contributor
There was a problem hiding this comment.
If the main issue if the potential naming conflict caused by multiple mover instances, can we track the existing MoverMetrics instances and their NNC mappings at the class level (i.e. through a class static field) to avoid the duplication?
| this.excludedPinnedBlocks = excludedPinnedBlocks; | ||
| this.nnc = nnc; | ||
| this.metrics = MoverMetrics.create(this); | ||
| this.metrics = nnc.getMoverMetrics(); |
Contributor
There was a problem hiding this comment.
We also need to add some UTs to reproduce the issue (without your fix) and validate the fix.
Contributor
|
@Jing9 @Happy-shi hello, anyone follow up on this issue? I had the same problem with balancer. 2023-03-06 17:40:53,264 ERROR org.apache.hadoop.hdfs.server.balancer.Balancer: Exiting balancer due an exception
org.apache.hadoop.metrics2.MetricsException: Metrics source Balancer-BP-332003681-10.196.164.22-1648632173322 already exists!
at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newSourceName(DefaultMetricsSystem.java:225)
at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.sourceName(DefaultMetricsSystem.java:198)
at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.register(MetricsSystemImpl.java:229)
at org.apache.hadoop.hdfs.server.balancer.BalancerMetrics.create(BalancerMetrics.java:55)
at org.apache.hadoop.hdfs.server.balancer.Balancer.<init>(Balancer.java:344)
at org.apache.hadoop.hdfs.server.balancer.Balancer.doBalance(Balancer.java:809)
at org.apache.hadoop.hdfs.server.balancer.Balancer.run(Balancer.java:847)
at org.apache.hadoop.hdfs.server.balancer.Balancer$Cli.run(Balancer.java:952)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
at org.apache.hadoop.hdfs.server.balancer.Balancer.main(Balancer.java:1102) |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-16867
Exiting Mover due to an exception in MoverMetrics.create