Skip to content

HADOOP-18624. Leaked calls in Client.java may cause ObserverNameNode OOM #5367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

HADOOP-18624. Leaked calls in Client.java may cause ObserverNameNode OOM #5367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,10 +1467,12 @@ Writable call(RPC.RpcKind rpcKind, Writable rpcRequest,
final Connection connection = getConnection(remoteId, call, serviceClass,
fallbackToSimpleAuth);

boolean success = false;
try {
checkAsyncCall();
try {
connection.sendRpcRequest(call); // send the rpc request
success = true;
} catch (RejectedExecutionException e) {
throw new IOException("connection has been closed", e);
} catch (InterruptedException ie) {
Expand All @@ -1485,6 +1487,10 @@ Writable call(RPC.RpcKind rpcKind, Writable rpcRequest,
releaseAsyncCall();
}
throw e;
} finally {
if (!success) {
connection.calls.remove(call.id);
Copy link
Contributor

@xinglin xinglin Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sendRpcRequest(call) will try to add a pair of <call,buf> into rpcRequestQueue. Should we remove that on failure as well?

rpcRequestQueue.put(Pair.of(call, buf));

Copy link
Contributor Author

@ZanderXu ZanderXu Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xinglin for your comment.

We don't need to remove the call from rpcRequestQueue, because the rpcRequestThread will poll it and send to the connection.

Copy link
Contributor

@xinglin xinglin Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the change makes sense to me. Thanks,

}
}

if (isAsynchronousMode()) {
Expand Down