Skip to content

HDFS-16928. Both getCurrentEditLogTxid and getEditsFromTxid should be OperationCategory.WRITE #5419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HDFS-16928. Both getCurrentEditLogTxid and getEditsFromTxid should be OperationCategory.WRITE #5419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...t/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2368,7 +2368,7 @@ public void checkAccess(String path, FsAction mode) throws IOException {
public long getCurrentEditLogTxid() throws IOException {
String operationName = "getCurrentEditLogTxid";
checkNNStartup();
namesystem.checkOperation(OperationCategory.READ); // only active
namesystem.checkOperation(OperationCategory.WRITE); // only active
namesystem.checkSuperuserPrivilege(operationName);
// if it's not yet open for write, we may be in the process of transitioning
// from standby to active and may not yet know what the latest committed
Expand Down Expand Up @@ -2398,7 +2398,7 @@ private static FSEditLogOp readOp(EditLogInputStream elis)
public EventBatchList getEditsFromTxid(long txid) throws IOException {
String operationName = "getEditsFromTxid";
checkNNStartup();
namesystem.checkOperation(OperationCategory.READ); // only active
namesystem.checkOperation(OperationCategory.WRITE); // only active
namesystem.checkSuperuserPrivilege(operationName);
int maxEventsPerRPC = nn.getConf().getInt(
DFSConfigKeys.DFS_NAMENODE_INOTIFY_MAX_EVENTS_PER_RPC_KEY,
Expand Down