You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new command and rpc method for Admin Service (& the required protobufs)
Provide an argument to start RM in safe mode which will only start Admin Service
Create a generic KV interface & generic LevelDB interface to access the DB
How was this patch tested?
Tested can't access the DB when RM is running.
Tested basic happy cases of get / set / del with valid & invalid arguments
Tested can access DB when RM can't start due to DB corruption - and can update DB in this case to fix RM state
Tested can't access when DB is not yet inited
Tested can't access if DB is being used by another RM process. Also RM can't start if RM is already started in safe mode & vice versa (this is because of level db locks)
Tested Conf store keys & RM DT Master keys
Unit test cases aren't really applicable here as all code changes are about tying together various pieces from AdminCLI to LevelDB rather than any functional logic
Found reliance on default encoding in org.apache.hadoop.yarn.server.resourcemanager.AdminService.accessDatabase(DatabaseAccessRequest):in org.apache.hadoop.yarn.server.resourcemanager.AdminService.accessDatabase(DatabaseAccessRequest): new String(byte[]) At AdminService.java:[line 1023]
Found reliance on default encoding in org.apache.hadoop.yarn.server.resourcemanager.AdminService.accessDatabase(DatabaseAccessRequest):in org.apache.hadoop.yarn.server.resourcemanager.AdminService.accessDatabase(DatabaseAccessRequest): String.getBytes() At AdminService.java:[line 1021]
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Requirement is captured in JIRA YARN-11473
Code Changes
How was this patch tested?
Unit test cases aren't really applicable here as all code changes are about tying together various pieces from AdminCLI to LevelDB rather than any functional logic