Skip to content

YARN-11476. Add NodeManager metric for event queue size of dispatcher #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

YARN-11476. Add NodeManager metric for event queue size of dispatcher #5599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcbeede
metrics
cxzl25 Apr 27, 2023
aa60c6b
style
cxzl25 Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...rver-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,12 @@
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.ConcurrentSkipListMap;
import java.util.concurrent.ScheduledThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;

import org.apache.hadoop.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;

public class NodeManager extends CompositeService
implements EventHandler<NodeManagerEvent>, NodeManagerMXBean {

Expand Down Expand Up @@ -149,6 +153,8 @@ public int getExitCode() {

private NMLogAggregationStatusTracker nmLogAggregationStatusTracker;

private ScheduledThreadPoolExecutor eventQueueMetricExecutor;

/**
* Default Container State transition listener.
*/
Expand Down Expand Up @@ -498,6 +504,16 @@ protected void serviceInit(Configuration conf) throws Exception {
registerMXBean();

context.getContainerExecutor().start();

eventQueueMetricExecutor = new ScheduledThreadPoolExecutor(1,
new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat("EventQueueSizeMetricThread").build());
eventQueueMetricExecutor.scheduleAtFixedRate(() -> {
metrics.setNmDispatcherEventQueueSize(dispatcher.getEventQueueSize());
metrics.setSchedulerEventQueueSize(
containerManager.getDispatcher().getEventQueueSize());
}, 1, 1, TimeUnit.SECONDS);

super.serviceInit(conf);
// TODO add local dirs to del
}
Expand Down Expand Up @@ -525,6 +541,9 @@ protected void serviceStop() throws Exception {
// release of NMLevelDBStore.
stopRecoveryStore();
}
if (eventQueueMetricExecutor != null) {
eventQueueMetricExecutor.shutdownNow();
}
}

public String getName() {
Expand Down
21 changes: 21 additions & 0 deletions ...r/src/main/java/org/apache/hadoop/yarn/server/nodemanager/metrics/NodeManagerMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ public class NodeManagerMetrics {
@Metric("Container localization time in milliseconds")
MutableRate localizationDurationMillis;

@Metric("# of nm dispatcher event queue size")
MutableGaugeInt nmDispatcherEventQueueSize;
@Metric("# of scheduler dispatcher event queue size")
MutableGaugeInt schedulerDispatcherEventQueueSize;

// CHECKSTYLE:ON:VisibilityModifier

private JvmMetrics jvmMetrics = null;
Expand Down Expand Up @@ -481,4 +486,20 @@ public void localizationCacheHitMiss(long size) {
public void localizationComplete(long downloadMillis) {
localizationDurationMillis.add(downloadMillis);
}

public int getNmDispatcherEventQueueSize() {
return nmDispatcherEventQueueSize.value();
}

public void setNmDispatcherEventQueueSize(int nmDispatcherEventQueueSize) {
this.nmDispatcherEventQueueSize.set(nmDispatcherEventQueueSize);
}

public int getSchedulerEventQueueSize() {
return schedulerDispatcherEventQueueSize.value();
}

public void setSchedulerEventQueueSize(int schedulerEventQueueSize) {
this.schedulerDispatcherEventQueueSize.set(schedulerEventQueueSize);
}
}