Skip to content

HADOOP-18723. Add detail logs if distcp checksum mismatch #5603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

HADOOP-18723. Add detail logs if distcp checksum mismatch #5603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d09a62
HADOOP-18723. Add detail logs if distcp checksum mismatch
symious Apr 27, 2023
b1060a8
HADOOP-18723. Remove unused imports
symious Apr 27, 2023
a832a9b
HADOOP-18723. Fix checkstyle
symious Apr 27, 2023
462b340
HADOOP-18723. Add log only for mismatch
symious May 3, 2023
c99bcea
HADOOP-18723. Replace deprecated function
symious May 3, 2023
c73e1da
HADOOP-18723. Add source and target path
symious May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/util/DistCpUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,9 @@ public static CopyMapper.ChecksumComparison checksumsAreEqual(
} else if (sourceChecksum.equals(targetChecksum)) {
return CopyMapper.ChecksumComparison.TRUE;
}
LOG.info("Checksum not equal. Source path: {}, source checksum: {}, target path {}, " +
"target checksum: {}",
source, sourceChecksum, target, targetChecksum);
return CopyMapper.ChecksumComparison.FALSE;
}

Expand Down
5 changes: 4 additions & 1 deletion ...p-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.hadoop.tools.mapred;

import org.apache.hadoop.fs.contract.ContractTestUtils;
import org.assertj.core.api.Assertions;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.hadoop.conf.Configuration;
Expand Down Expand Up @@ -513,7 +514,8 @@ public void testCommitWithChecksumMismatchWithoutSkipCrc()

private void testCommitWithChecksumMismatch(boolean skipCrc)
throws IOException {

GenericTestUtils.LogCapturer log = GenericTestUtils.LogCapturer.captureLogs(
LoggerFactory.getLogger(DistCpUtils.class));
TaskAttemptContext taskAttemptContext = getTaskAttemptContext(config);
JobContext jobContext = new JobContextImpl(
taskAttemptContext.getConfiguration(),
Expand Down Expand Up @@ -569,6 +571,7 @@ private void testCommitWithChecksumMismatch(boolean skipCrc)
fs, new Path(sourceBase + srcFilename), null,
fs, new Path(targetBase + srcFilename),
sourceCurrStatus.getLen()));
Assertions.assertThat(log.getOutput()).contains("Checksum not equal");
} catch(IOException exception) {
if (skipCrc) {
LOG.error("Unexpected exception is found", exception);
Expand Down