Skip to content

HADOOP-18748 Optimize Configuration.handleDeprecation #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

HADOOP-18748 Optimize Configuration.handleDeprecation #5685

wants to merge 3 commits into from

Conversation

@alkis
Copy link

@alkis alkis commented May 22, 2023 •
edited
Loading

Description of PR

Optimize Configuration.handleDeprecation by adding a fastpath for when a property is not deprecated. While at it factor out property propagation so that it can be reused by both main and overlay properties.

How was this patch tested?

Existing tests:

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@alkis alkis force-pushed the optimize-configuration-get branch 2 times, most recently from b46d00c to 6db71fe Compare May 22, 2023 13:18
@hadoop-yetus
Copy link

hadoop-yetus commented May 22, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 39m 31s trunk passed
+1 💚 compile 16m 21s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 15m 8s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 12s trunk passed
+1 💚 mvnsite 1m 28s trunk passed
+1 💚 javadoc 1m 17s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 51s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 38s trunk passed
+1 💚 shadedclient 23m 1s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 52s the patch passed
+1 💚 compile 14m 57s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 14m 57s the patch passed
+1 💚 compile 14m 57s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 14m 57s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 7s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
+1 💚 mvnsite 1m 33s the patch passed
+1 💚 javadoc 1m 5s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 49s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
-1 ❌ spotbugs 2m 40s /new-spotbugs-hadoop-common-project_hadoop-common.html hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shadedclient 23m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 1s hadoop-common in the patch passed.
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
185m 1s
Reason Tests
SpotBugs module:hadoop-common-project/hadoop-common
Inconsistent synchronization of org.apache.hadoop.conf.Configuration.overlay; locked 60% of time Unsynchronized access at Configuration.java:60% of time Unsynchronized access at Configuration.java:[line 744]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/1/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 7b9924b03a27 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 980a042
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/1/testReport/
Max. process+thread count 2997 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented May 22, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 2s trunk passed
+1 💚 compile 16m 38s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 15m 33s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 10s trunk passed
+1 💚 mvnsite 1m 40s trunk passed
+1 💚 javadoc 1m 9s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 52s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 40s trunk passed
+1 💚 shadedclient 22m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 52s the patch passed
+1 💚 compile 16m 12s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 16m 12s the patch passed
+1 💚 compile 15m 33s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 15m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 2s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 3 new + 108 unchanged - 0 fixed = 111 total (was 108)
+1 💚 mvnsite 1m 40s the patch passed
+1 💚 javadoc 1m 11s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
-1 ❌ spotbugs 2m 45s /new-spotbugs-hadoop-common-project_hadoop-common.html hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shadedclient 22m 27s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 1s hadoop-common in the patch passed.
+1 💚 asflicense 1m 0s The patch does not generate ASF License warnings.
181m 19s
Reason Tests
SpotBugs module:hadoop-common-project/hadoop-common
Inconsistent synchronization of org.apache.hadoop.conf.Configuration.overlay; locked 75% of time Unsynchronized access at Configuration.java:75% of time Unsynchronized access at Configuration.java:[line 745]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/2/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 33fe50a049b7 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6db71fe
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/2/testReport/
Max. process+thread count 1263 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented May 22, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 45s trunk passed
+1 💚 compile 16m 43s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 15m 23s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 14s trunk passed
+1 💚 mvnsite 1m 37s trunk passed
+1 💚 javadoc 1m 18s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 42s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 36s trunk passed
+1 💚 shadedclient 22m 7s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 16m 9s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 16m 9s the patch passed
+1 💚 compile 15m 30s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 15m 30s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 9s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 3 new + 108 unchanged - 0 fixed = 111 total (was 108)
+1 💚 mvnsite 1m 35s the patch passed
+1 💚 javadoc 1m 12s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 48s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
-1 ❌ spotbugs 2m 39s /new-spotbugs-hadoop-common-project_hadoop-common.html hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shadedclient 22m 13s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 49s hadoop-common in the patch passed.
+1 💚 asflicense 1m 0s The patch does not generate ASF License warnings.
180m 38s
Reason Tests
SpotBugs module:hadoop-common-project/hadoop-common
Inconsistent synchronization of org.apache.hadoop.conf.Configuration.overlay; locked 75% of time Unsynchronized access at Configuration.java:75% of time Unsynchronized access at Configuration.java:[line 745]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/3/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 5d28f5b45641 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6db71fe
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/3/testReport/
Max. process+thread count 1263 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@alkis alkis force-pushed the optimize-configuration-get branch 2 times, most recently from 2a58c7f to f8a8bba Compare May 23, 2023 05:37
@hadoop-yetus
Copy link

hadoop-yetus commented May 23, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 32m 52s trunk passed
+1 💚 compile 17m 28s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 15m 46s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 6s trunk passed
+1 💚 mvnsite 1m 33s trunk passed
+1 💚 javadoc 1m 10s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 44s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 37s trunk passed
+1 💚 shadedclient 22m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 50s the patch passed
+1 💚 compile 14m 55s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 14m 55s the patch passed
+1 💚 compile 14m 34s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 14m 34s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 7s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 3 new + 108 unchanged - 0 fixed = 111 total (was 108)
+1 💚 mvnsite 1m 34s the patch passed
+1 💚 javadoc 1m 9s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 50s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 40s the patch passed
+1 💚 shadedclient 22m 21s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 24s hadoop-common in the patch passed.
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
177m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/5/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux bfed62771448 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f8a8bba
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/5/testReport/
Max. process+thread count 1263 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented May 23, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 19s trunk passed
+1 💚 compile 16m 23s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 16m 37s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 16s trunk passed
+1 💚 mvnsite 1m 39s trunk passed
+1 💚 javadoc 1m 19s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 48s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 57s trunk passed
+1 💚 shadedclient 26m 40s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 58s the patch passed
+1 💚 compile 18m 17s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 18m 17s the patch passed
+1 💚 compile 15m 49s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 15m 50s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 5s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 3 new + 108 unchanged - 0 fixed = 111 total (was 108)
+1 💚 mvnsite 1m 35s the patch passed
+1 💚 javadoc 1m 10s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 47s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 46s the patch passed
+1 💚 shadedclient 25m 16s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 58s hadoop-common in the patch passed.
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
191m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/4/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux f3d9a995e805 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f8a8bba
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/4/testReport/
Max. process+thread count 1500 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

steveloughran commented May 23, 2023

you know, if we could speed up the basic .get() it can only be good. at the same time, this is such a broadly used piece of code, we are scared of doing anything risky to it.

what can we do in terms of testing that all this is good? I'm thinking of concurrency as well as everything else?

@alkis
Copy link
Author

alkis commented May 23, 2023 •
edited
Loading

you know, if we could speed up the basic .get() it can only be good. at the same time, this is such a broadly used piece of code, we are scared of doing anything risky to it.

what can we do in terms of testing that all this is good? I'm thinking of concurrency as well as everything else?

That's a good point. I have specifically avoided a larger rewrite to reduce the risks in breaking the implementation. Testing is quite wide since Configuration is used pervasively in most tests and in addition there are specific tests for its basic and deprecated keys usages. In terms of concurrency I also avoided changing it to avoid risks - the locking is the same as before.

Can you advice on how to apply this change in other branches as well such that older versions can receive the benefits?

@alkis alkis force-pushed the optimize-configuration-get branch from f8a8bba to 4ebb9de Compare May 30, 2023 07:49
@hadoop-yetus
Copy link

hadoop-yetus commented May 30, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 17s trunk passed
+1 💚 compile 18m 10s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 16m 16s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 13s trunk passed
+1 💚 mvnsite 1m 42s trunk passed
+1 💚 javadoc 1m 16s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 50s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 40s trunk passed
+1 💚 shadedclient 24m 55s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 55s the patch passed
+1 💚 compile 17m 51s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 17m 51s the patch passed
+1 💚 compile 16m 37s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 16m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 10s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 3 new + 108 unchanged - 0 fixed = 111 total (was 108)
+1 💚 mvnsite 1m 28s the patch passed
+1 💚 javadoc 1m 5s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 48s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 36s the patch passed
+1 💚 shadedclient 22m 38s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 31s hadoop-common in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
192m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/6/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 336fa8421b14 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 4ebb9de
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/6/testReport/
Max. process+thread count 1782 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/6/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

steveloughran commented Jun 1, 2023

regarding older versions, once in trunk it can be cherry picked into branch-3.3 to ship in 3.3.9; you'd do that by submitting a new PR against the branch with the patch cherrypicked from trunk to it...that lets yetus do its reviewing again. We wouldn't expect to do any code review at this point, just validate the backport worked

steveloughran
steveloughran requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have some minor changes here. but will try to seek broader review as the blast radius of a regression spans so many projects.

@alkis alkis force-pushed the optimize-configuration-get branch from 4ebb9de to 601c265 Compare June 1, 2023 16:35
@alkis alkis requested a review from steveloughran June 1, 2023 16:35
@hadoop-yetus
Copy link

hadoop-yetus commented Jun 1, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 24s trunk passed
+1 💚 compile 16m 9s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 14m 43s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 12s trunk passed
+1 💚 mvnsite 1m 34s trunk passed
+1 💚 javadoc 1m 15s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 46s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 38s trunk passed
+1 💚 shadedclient 23m 12s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 50s the patch passed
+1 💚 compile 16m 13s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 16m 13s the patch passed
+1 💚 compile 15m 26s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 15m 26s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 6s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
+1 💚 mvnsite 1m 35s the patch passed
+1 💚 javadoc 1m 8s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 53s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 41s the patch passed
-1 ❌ shadedclient 22m 45s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 18m 58s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
182m 19s
Reason Tests
Failed junit tests hadoop.fs.shell.TestCopyFromLocal
hadoop.io.file.tfile.TestVLong
hadoop.fs.impl.prefetch.TestBlockCache
hadoop.fs.permission.TestFsPermission
hadoop.fs.contract.rawlocal.TestRawlocalContractSetTimes
hadoop.fs.TestAvroFSInput
hadoop.conf.TestDeprecatedKeys
hadoop.fs.contract.localfs.TestLocalFSContractGetFileStatus
hadoop.security.alias.TestCredentialProviderFactory
hadoop.fs.shell.TestCpCommand
hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
hadoop.fs.contract.rawlocal.TestRawlocalContractSeek
hadoop.fs.TestStat
hadoop.io.TestSequenceFileSync
hadoop.io.file.tfile.TestTFileNoneCodecsJClassComparatorByteArrays
hadoop.fs.contract.localfs.TestLocalFSContractOpen
hadoop.fs.shell.TestLs
hadoop.fs.TestGetFileBlockLocations
hadoop.fs.contract.sftp.TestSFTPContractSeek
hadoop.fs.contract.rawlocal.TestRawLocalContractVectoredRead
hadoop.fs.TestFsShellCopy
hadoop.fs.viewfs.TestFcPermissionsLocalFs
hadoop.fs.TestLocalDirAllocator
hadoop.fs.TestPath
hadoop.conf.TestConfiguration
hadoop.fs.TestLocalFSFileContextMainOperations
hadoop.fs.viewfs.TestChRootedFs
hadoop.io.file.tfile.TestTFileByteArrays
hadoop.conf.TestReconfiguration
hadoop.io.file.tfile.TestTFileComparators
hadoop.fs.TestFileSystemCanonicalization
hadoop.io.file.tfile.TestTFile
hadoop.fs.contract.localfs.TestLocalFSContractStreamIOStatistics
hadoop.fs.TestFcLocalFsPermission
hadoop.fs.contract.localfs.TestLocalFSContractMkdir
hadoop.fs.TestLocalFSCopyFromLocal
hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
hadoop.fs.TestLocalFSFileContextCreateMkdir
hadoop.fs.shell.find.TestFind
hadoop.fs.contract.rawlocal.TestRawlocalContractRename
hadoop.io.TestSequenceFileSerialization
hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig
hadoop.fs.TestChecksumFileSystem
hadoop.fs.contract.rawlocal.TestRawlocalContractCreate
hadoop.conf.TestConfigurationDeprecation
hadoop.util.TestGenericOptionsParser
hadoop.fs.viewfs.TestChRootedFileSystem
hadoop.fs.TestHarFileSystemBasics
hadoop.fs.TestLocalFsFCStatistics
hadoop.fs.TestFileSystemCaching
hadoop.fs.TestFileContextResolveAfs
hadoop.security.TestUserGroupInformation
hadoop.fs.shell.TestCopy
hadoop.io.TestSequenceFile
hadoop.fs.viewfs.TestFcMainOperationsLocalFs
hadoop.fs.store.TestDataBlocks
hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays
hadoop.net.TestSwitchMapping
hadoop.io.file.tfile.TestTFileSeek
hadoop.security.alias.TestCredShell
hadoop.fs.ftp.TestFTPFileSystem
hadoop.fs.TestListFiles
hadoop.fs.TestRawLocalFileSystemContract
hadoop.net.TestScriptBasedMapping
hadoop.io.file.tfile.TestTFileComparator2
hadoop.fs.contract.localfs.TestLocalFSContractContentSummary
hadoop.util.TestJsonSerialization
hadoop.io.TestSetFile
hadoop.fs.TestLocalFileSystemPermission
hadoop.io.TestSequenceFileAppend
hadoop.fs.TestSymlinkLocalFSFileSystem
hadoop.fs.TestFileUtil
hadoop.security.TestLdapGroupsMapping
hadoop.fs.shell.find.TestPrint0
hadoop.io.nativeio.TestNativeIO
hadoop.fs.TestFsShellReturnCode
hadoop.fs.contract.localfs.TestLocalFSContractCreate
hadoop.fs.TestTruncatedInputBug
hadoop.fs.TestFsShellList
hadoop.fs.TestSymlinkLocalFSFileContext
hadoop.fs.contract.rawlocal.TestRawlocalContractMkdir
hadoop.fs.TestTrash
hadoop.fs.shell.TestAclCommands
hadoop.security.TestLdapGroupsMappingWithBindUserSwitch
hadoop.io.file.tfile.TestTFileSplit
hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeLocalFileSystem
hadoop.security.token.TestDtUtilShell
hadoop.fs.shell.find.TestPrint
hadoop.io.file.tfile.TestTFileNoneCodecsByteArrays
hadoop.fs.TestDefaultUri
hadoop.fs.contract.localfs.TestLocalFSContractVectoredRead
hadoop.fs.contract.localfs.TestLocalFSContractLoaded
hadoop.fs.TestFsShellTouch
hadoop.fs.shell.TestCopyPreserveFlag
hadoop.fs.viewfs.TestViewFsOverloadSchemeListStatus
hadoop.fs.contract.localfs.TestLocalFSContractSeek
hadoop.fs.TestFileContext
hadoop.fs.contract.rawlocal.TestRawlocalContractDelete
hadoop.io.TestMapFile
hadoop.fs.shell.TestPathData
hadoop.fs.shell.TestFsShellConcat
hadoop.net.TestScriptBasedMappingWithDependency
hadoop.fs.contract.rawlocal.TestRawlocalContractGetFileStatus
hadoop.fs.contract.localfs.TestLocalFSContractDelete
hadoop.crypto.key.TestKeyShell
hadoop.fs.contract.rawlocal.TestRawlocalContractOpen
hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
hadoop.net.TestStaticMapping
hadoop.fs.TestFileContextDeleteOnExit
hadoop.fs.sftp.TestSFTPFileSystem
hadoop.fs.shell.TestCopyToLocal
hadoop.fs.shell.TestTextCommand
hadoop.io.TestBloomMapFile
hadoop.io.compress.TestBZip2Codec
hadoop.fs.contract.rawlocal.TestRawlocalContractPathHandle
hadoop.fs.shell.find.TestName
hadoop.fs.viewfs.TestViewFsLocalFs
hadoop.fs.contract.localfs.TestLocalFSContractSetTimes
hadoop.fs.TestFcLocalFsUtil
hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
hadoop.io.compress.lz4.TestLz4CompressorDecompressor
hadoop.io.file.tfile.TestTFileUnsortedByteArrays
hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
hadoop.fs.viewfs.TestHCFSMountTableConfigLoader
hadoop.io.file.tfile.TestTFileSeqFileComparison
hadoop.fs.TestFSMainOperationsLocalFileSystem
hadoop.fs.contract.rawlocal.TestRawlocalContractAppend
hadoop.metrics2.sink.TestRollingFileSystemSinkWithLocal
hadoop.io.compress.TestCodec
hadoop.fs.contract.localfs.TestLocalFSContractRename
hadoop.fs.viewfs.TestViewFsTrash
hadoop.io.file.tfile.TestTFileNoneCodecsStreams
hadoop.fs.shell.find.TestIname
hadoop.io.TestArrayFile
hadoop.io.file.tfile.TestTFileStreams
hadoop.fs.contract.localfs.TestLocalFSContractAppend
hadoop.fs.TestLocalFileSystem
hadoop.security.ssl.TestSSLFactory
hadoop.fs.TestChecksumFs
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/7/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 0037820e4654 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 601c265
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/7/testReport/
Max. process+thread count 1981 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/7/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

steveloughran commented Jun 7, 2023

  1. everything broke. As I warned, Configuration is sensitive piece of code.
  2. can you not rebase and force push unless you absolutely have to, as it complicates reviewing. thanks.

@alkis
Copy link
Author

alkis commented Jun 7, 2023 •
edited
Loading

  1. everything broke. As I warned, Configuration is sensitive piece of code.

Ah this broke after addressing the first round of comments and I accidentally introduced a bug. Fixed now.

  1. can you not rebase and force push unless you absolutely have to, as it complicates reviewing. thanks.

Sure. I will merge instead if that's more convenient.

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 7, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 23s trunk passed
+1 💚 compile 16m 24s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 15m 8s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 18s trunk passed
+1 💚 mvnsite 1m 32s trunk passed
+1 💚 javadoc 1m 22s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 48s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 56s trunk passed
+1 💚 shadedclient 23m 7s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 52s the patch passed
+1 💚 compile 15m 42s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 15m 42s the patch passed
+1 💚 compile 14m 52s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 14m 52s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 6s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
+1 💚 mvnsite 1m 32s the patch passed
+1 💚 javadoc 1m 8s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 42s the patch passed
-1 ❌ shadedclient 22m 22s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 18m 44s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 asflicense 1m 6s The patch does not generate ASF License warnings.
188m 18s
Reason Tests
Failed junit tests hadoop.fs.shell.TestCopyFromLocal
hadoop.io.file.tfile.TestVLong
hadoop.fs.impl.prefetch.TestBlockCache
hadoop.fs.permission.TestFsPermission
hadoop.fs.contract.rawlocal.TestRawlocalContractSetTimes
hadoop.fs.TestAvroFSInput
hadoop.conf.TestDeprecatedKeys
hadoop.fs.contract.localfs.TestLocalFSContractGetFileStatus
hadoop.security.alias.TestCredentialProviderFactory
hadoop.fs.shell.TestCpCommand
hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
hadoop.fs.contract.rawlocal.TestRawlocalContractSeek
hadoop.fs.TestStat
hadoop.io.TestSequenceFileSync
hadoop.io.file.tfile.TestTFileNoneCodecsJClassComparatorByteArrays
hadoop.fs.contract.localfs.TestLocalFSContractOpen
hadoop.fs.shell.TestLs
hadoop.fs.TestGetFileBlockLocations
hadoop.fs.contract.sftp.TestSFTPContractSeek
hadoop.fs.contract.rawlocal.TestRawLocalContractVectoredRead
hadoop.fs.TestFsShellCopy
hadoop.fs.viewfs.TestFcPermissionsLocalFs
hadoop.fs.TestLocalDirAllocator
hadoop.fs.TestPath
hadoop.conf.TestConfiguration
hadoop.fs.TestLocalFSFileContextMainOperations
hadoop.fs.viewfs.TestChRootedFs
hadoop.io.file.tfile.TestTFileByteArrays
hadoop.conf.TestReconfiguration
hadoop.io.file.tfile.TestTFileComparators
hadoop.fs.TestFileSystemCanonicalization
hadoop.io.file.tfile.TestTFile
hadoop.fs.contract.localfs.TestLocalFSContractStreamIOStatistics
hadoop.fs.TestFcLocalFsPermission
hadoop.fs.contract.localfs.TestLocalFSContractMkdir
hadoop.fs.TestLocalFSCopyFromLocal
hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
hadoop.fs.TestLocalFSFileContextCreateMkdir
hadoop.fs.shell.find.TestFind
hadoop.fs.contract.rawlocal.TestRawlocalContractRename
hadoop.io.TestSequenceFileSerialization
hadoop.fs.viewfs.TestViewFSOverloadSchemeCentralMountTableConfig
hadoop.fs.TestChecksumFileSystem
hadoop.fs.contract.rawlocal.TestRawlocalContractCreate
hadoop.conf.TestConfigurationDeprecation
hadoop.util.TestGenericOptionsParser
hadoop.fs.viewfs.TestChRootedFileSystem
hadoop.fs.TestHarFileSystemBasics
hadoop.fs.TestLocalFsFCStatistics
hadoop.fs.TestFileSystemCaching
hadoop.fs.TestFileContextResolveAfs
hadoop.security.TestUserGroupInformation
hadoop.fs.shell.TestCopy
hadoop.io.TestSequenceFile
hadoop.fs.viewfs.TestFcMainOperationsLocalFs
hadoop.fs.store.TestDataBlocks
hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays
hadoop.net.TestSwitchMapping
hadoop.io.file.tfile.TestTFileSeek
hadoop.security.alias.TestCredShell
hadoop.fs.ftp.TestFTPFileSystem
hadoop.fs.TestListFiles
hadoop.fs.TestRawLocalFileSystemContract
hadoop.net.TestScriptBasedMapping
hadoop.io.file.tfile.TestTFileComparator2
hadoop.fs.contract.localfs.TestLocalFSContractContentSummary
hadoop.util.TestJsonSerialization
hadoop.io.TestSetFile
hadoop.fs.TestLocalFileSystemPermission
hadoop.io.TestSequenceFileAppend
hadoop.fs.TestSymlinkLocalFSFileSystem
hadoop.fs.TestFileUtil
hadoop.security.TestLdapGroupsMapping
hadoop.fs.shell.find.TestPrint0
hadoop.io.nativeio.TestNativeIO
hadoop.fs.TestFsShellReturnCode
hadoop.fs.contract.localfs.TestLocalFSContractCreate
hadoop.fs.TestTruncatedInputBug
hadoop.fs.TestFsShellList
hadoop.fs.TestSymlinkLocalFSFileContext
hadoop.fs.contract.rawlocal.TestRawlocalContractMkdir
hadoop.fs.TestTrash
hadoop.fs.shell.TestAclCommands
hadoop.security.TestLdapGroupsMappingWithBindUserSwitch
hadoop.io.file.tfile.TestTFileSplit
hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeLocalFileSystem
hadoop.security.token.TestDtUtilShell
hadoop.fs.shell.find.TestPrint
hadoop.io.file.tfile.TestTFileNoneCodecsByteArrays
hadoop.fs.TestDefaultUri
hadoop.fs.contract.localfs.TestLocalFSContractVectoredRead
hadoop.fs.contract.localfs.TestLocalFSContractLoaded
hadoop.fs.TestFsShellTouch
hadoop.fs.shell.TestCopyPreserveFlag
hadoop.fs.viewfs.TestViewFsOverloadSchemeListStatus
hadoop.fs.contract.localfs.TestLocalFSContractSeek
hadoop.fs.TestFileContext
hadoop.fs.contract.rawlocal.TestRawlocalContractDelete
hadoop.io.TestMapFile
hadoop.fs.shell.TestPathData
hadoop.fs.shell.TestFsShellConcat
hadoop.net.TestScriptBasedMappingWithDependency
hadoop.fs.contract.rawlocal.TestRawlocalContractGetFileStatus
hadoop.fs.contract.localfs.TestLocalFSContractDelete
hadoop.crypto.key.TestKeyShell
hadoop.fs.contract.rawlocal.TestRawlocalContractOpen
hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
hadoop.net.TestStaticMapping
hadoop.fs.TestFileContextDeleteOnExit
hadoop.fs.sftp.TestSFTPFileSystem
hadoop.fs.shell.TestCopyToLocal
hadoop.fs.shell.TestTextCommand
hadoop.io.TestBloomMapFile
hadoop.io.compress.TestBZip2Codec
hadoop.fs.contract.rawlocal.TestRawlocalContractPathHandle
hadoop.fs.shell.find.TestName
hadoop.fs.viewfs.TestViewFsLocalFs
hadoop.fs.contract.localfs.TestLocalFSContractSetTimes
hadoop.fs.TestFcLocalFsUtil
hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
hadoop.io.compress.lz4.TestLz4CompressorDecompressor
hadoop.io.file.tfile.TestTFileUnsortedByteArrays
hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
hadoop.fs.viewfs.TestHCFSMountTableConfigLoader
hadoop.io.file.tfile.TestTFileSeqFileComparison
hadoop.fs.TestFSMainOperationsLocalFileSystem
hadoop.fs.contract.rawlocal.TestRawlocalContractAppend
hadoop.metrics2.sink.TestRollingFileSystemSinkWithLocal
hadoop.io.compress.TestCodec
hadoop.fs.contract.localfs.TestLocalFSContractRename
hadoop.fs.viewfs.TestViewFsTrash
hadoop.io.file.tfile.TestTFileNoneCodecsStreams
hadoop.fs.shell.find.TestIname
hadoop.io.TestArrayFile
hadoop.io.file.tfile.TestTFileStreams
hadoop.fs.contract.localfs.TestLocalFSContractAppend
hadoop.fs.TestLocalFileSystem
hadoop.security.ssl.TestSSLFactory
hadoop.fs.TestChecksumFs
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/8/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 15575c617a8b 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / cd6b6c5
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/8/testReport/
Max. process+thread count 1488 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/8/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 7, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 43s trunk passed
+1 💚 compile 17m 26s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 14m 31s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 21s trunk passed
+1 💚 mvnsite 1m 39s trunk passed
+1 💚 javadoc 1m 24s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 51s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 54s trunk passed
+1 💚 shadedclient 22m 48s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 14m 57s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 14m 57s the patch passed
+1 💚 compile 14m 12s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 14m 12s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 8s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
+1 💚 mvnsite 1m 31s the patch passed
+1 💚 javadoc 1m 7s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 32s the patch passed
+1 💚 shadedclient 22m 28s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 32s hadoop-common in the patch passed.
-1 ❌ asflicense 1m 7s /results-asflicense.txt The patch generated 1 ASF License warnings.
187m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/12/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 6dfc96c2a75e 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2f1a2ce
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/12/testReport/
Max. process+thread count 3159 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/12/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 7, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 43m 29s trunk passed
+1 💚 compile 17m 9s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 17m 5s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 25s trunk passed
+1 💚 mvnsite 1m 44s trunk passed
+1 💚 javadoc 3m 22s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 48s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 3m 9s trunk passed
+1 💚 shadedclient 25m 0s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 50s the patch passed
+1 💚 compile 14m 59s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 14m 59s the patch passed
+1 💚 compile 14m 29s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 14m 29s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 8s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
+1 💚 mvnsite 1m 35s the patch passed
+1 💚 javadoc 1m 7s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 36s the patch passed
+1 💚 shadedclient 22m 43s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 30s hadoop-common in the patch passed.
-1 ❌ asflicense 1m 6s /results-asflicense.txt The patch generated 1 ASF License warnings.
195m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/9/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 1ab18fc6a992 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2f1a2ce
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/9/testReport/
Max. process+thread count 3149 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/9/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 7, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 44m 23s trunk passed
+1 💚 compile 17m 31s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 15m 46s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 14s trunk passed
+1 💚 mvnsite 1m 32s trunk passed
+1 💚 javadoc 1m 17s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 42s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 55s trunk passed
+1 💚 shadedclient 25m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 50s the patch passed
+1 💚 compile 16m 39s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 16m 39s the patch passed
+1 💚 compile 15m 48s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 15m 48s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 0s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
+1 💚 mvnsite 1m 28s the patch passed
+1 💚 javadoc 1m 0s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 42s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 37s the patch passed
+1 💚 shadedclient 25m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 8s hadoop-common in the patch passed.
-1 ❌ asflicense 0m 56s /results-asflicense.txt The patch generated 1 ASF License warnings.
198m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/13/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux bd9b5ce8bead 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 593c3c9
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/13/testReport/
Max. process+thread count 2060 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/13/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 7, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 45m 18s trunk passed
+1 💚 compile 22m 25s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 17m 18s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 13s trunk passed
+1 💚 mvnsite 1m 32s trunk passed
+1 💚 javadoc 1m 20s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 46s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 3m 1s trunk passed
+1 💚 shadedclient 25m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 16m 47s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 16m 47s the patch passed
+1 💚 compile 15m 47s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 15m 47s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 1s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
+1 💚 mvnsite 1m 29s the patch passed
+1 💚 javadoc 0m 59s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 42s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 35s the patch passed
+1 💚 shadedclient 25m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 32s hadoop-common in the patch passed.
-1 ❌ asflicense 0m 57s /results-asflicense.txt The patch generated 1 ASF License warnings.
206m 6s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/11/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux d79f61d6f082 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2f1a2ce
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/11/testReport/
Max. process+thread count 1235 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/11/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 7, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 48m 30s trunk passed
+1 💚 compile 22m 53s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 19m 7s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 15s trunk passed
+1 💚 mvnsite 1m 37s trunk passed
+1 💚 javadoc 1m 18s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 42s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 3m 6s trunk passed
+1 💚 shadedclient 26m 34s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 54s the patch passed
+1 💚 compile 17m 41s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 17m 41s the patch passed
+1 💚 compile 16m 15s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 16m 15s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 0s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 108 unchanged - 0 fixed = 110 total (was 108)
+1 💚 mvnsite 1m 32s the patch passed
+1 💚 javadoc 1m 1s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 43s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 45s the patch passed
+1 💚 shadedclient 26m 0s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 19m 33s hadoop-common in the patch passed.
-1 ❌ asflicense 0m 58s /results-asflicense.txt The patch generated 1 ASF License warnings.
215m 53s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/10/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux a15235b641e3 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2f1a2ce
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/10/testReport/
Max. process+thread count 1253 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/10/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

steveloughran commented Jun 7, 2023

ok, style failures

./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:754:    Properties overlay = getOverlay();:16: 'overlay' hides a field. [HiddenField]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/ConfigurationBenchmark.java:1:package org.apache.hadoop.conf;public class ConfigurationBenchmark {:31: ';' is not followed by whitespace. [WhitespaceAfter]

the overlay one needs new variable name.

the ConfigurationBenchmark one looks like one of the PRs added a file, which somehow is still around for the style checking.

Probably the strategy there is actually do a squash commit and forced write, so we are down to a single patch. I know, it's not "elegant" but it ensures that there's no memory of a transient file

@alkis alkis force-pushed the optimize-configuration-get branch from 593c3c9 to c44a6a5 Compare June 8, 2023 08:10
@alkis
Copy link
Author

alkis commented Jun 8, 2023

ok, style failures

./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:754:    Properties overlay = getOverlay();:16: 'overlay' hides a field. [HiddenField]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/ConfigurationBenchmark.java:1:package org.apache.hadoop.conf;public class ConfigurationBenchmark {:31: ';' is not followed by whitespace. [WhitespaceAfter]

the overlay one needs new variable name.

the ConfigurationBenchmark one looks like one of the PRs added a file, which somehow is still around for the style checking.

Probably the strategy there is actually do a squash commit and forced write, so we are down to a single patch. I know, it's not "elegant" but it ensures that there's no memory of a transient file

Fixed the style failures and rewrote the history to sidestep the accidental addition of the file.

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 8, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 39m 8s trunk passed
+1 💚 compile 15m 40s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 14m 24s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 14s trunk passed
+1 💚 mvnsite 1m 37s trunk passed
+1 💚 javadoc 1m 14s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 51s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 36s trunk passed
+1 💚 shadedclient 22m 20s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 14m 55s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 14m 55s the patch passed
+1 💚 compile 14m 33s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 14m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 7s the patch passed
+1 💚 mvnsite 1m 36s the patch passed
+1 💚 javadoc 1m 4s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 51s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 2m 33s the patch passed
+1 💚 shadedclient 22m 27s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 33s hadoop-common in the patch passed.
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
180m 50s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/14/artifact/out/Dockerfile
GITHUB PR #5685
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 0048ebbdc570 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c44a6a5
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/14/testReport/
Max. process+thread count 1263 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5685/14/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@alkis
Copy link
Author

alkis commented Jun 16, 2023

@steveloughran any more thoughts on this?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

@github-actions github-actions bot added the Stale label Oct 20, 2025
@github-actions github-actions bot closed this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveloughran steveloughran Awaiting requested review from steveloughran

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alkis @hadoop-yetus @steveloughran