Skip to content

Conversation

@jojochuang
Copy link
Contributor

@jojochuang jojochuang commented Jul 24, 2023

Description of PR

Cast DecompressorStream.skip() properly.
Rebase an old patch.

How was this patch tested?

Unit test

For code changes:

  • [ X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…n calling skip(long).

Change-Id: I73183ce9c4ff55d71a0d46be4d5b11c48dbdef24
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I am unable to decode what incompatibility is being talked about in the Jira. I couldn't find anything incompatible here
https://issues.apache.org/jira/browse/HADOOP-12677?focusedCommentId=15072867&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15072867

And something happened to the build as well:
It got hung at the javadoc part:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5886/1/console

@github-actions
Copy link
Contributor

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

@github-actions github-actions bot added the Stale label Oct 17, 2025
@github-actions github-actions bot closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants