Skip to content

Conversation

@Aakansha99
Copy link

@Aakansha99 Aakansha99 commented Sep 4, 2023

Description of PR

The latest Hadoop version 3.3.3 which supports Java 8 compile and Java 8, Java 11 runtime i.e the code is compiled with Java 8 and can be run on both Java 8 and Java 11. The intention of this project is to extend this capability to support Java 17 for the runtime as well for Hadoop version 3.3.3 and above.

Made the following fix in this PR:

  1. Upgraded guice version from 4.0 to 5.1.0 to make it compatible for JRE17

  2. The current Mocktio (2.x) and PowerMocktio (1.7.x) versions are not compatible with Java 17 and Hence needs a
    appropriate version replacement.
    As per the OSS discussion as mentioned mocktio and PowerMocktio, The following version bump up is required
    Mockito core ---> Mockito inline 3.6.28
    PowerMockito ---> 2.0.0

  3. The JavaScript Engine has been removed from Java. Deprecated in Java 11, removed in Java 15.
    So, need to use different script engine, as GraalVM

How was this patch tested?

  • Tested the patch in local development environments of AWS EMR by building the code, running unit tests, and conducting integration tests.
  • We have also simulated distributed cluster environments by running individual Hadoop services locally.
  • Custom testing frameworks and performance tests ensure compatibility
  • Maintained code reviews, quality assurance and documentation precede integration into the EMR service, which maintained reliability and performance after integration as well

For code changes:

  • [No] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [Yes] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [Yes] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [Yes] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran
Copy link
Contributor

hi, welcome to contributing to hadoop.

every jar update should go in as its own pr, own tests, own update to LICENSE-binary (which does need updating, as we log versions in there). that makes it easier to isolate updates.

Mockito has an active update; your help getting that in should avoid some of the changes here. (this is an example of how we roll back a change...)
HADOOP-18860. Upgrade mockito version to 4.11.0 (#5977)

the graal stuff is its own issue too: how does that work with older releases?

@github-actions
Copy link
Contributor

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

@github-actions github-actions bot added the Stale label Oct 15, 2025
@github-actions github-actions bot closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants