HDFS-17107. Null Pointer Exception after turned on detail metric for namenode lock #6033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
https://issues.apache.org/jira/browse/HDFS-17107
This PR adds a null check for the
detailedHoldTimeMetricsif the metric is enabled.How was this patch tested?
dfs.namenode.lock.detailed-metrics.enabled=trueorg.apache.hadoop.hdfs.server.namenode.TestFSNamesystemLock#testFSWriteLockReportSuppressedThe test throws
IllegalArgumentExceptionas expected.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?