HADOOP-18800. Bad ipc.client.connection.idle-scan-interval.ms cause resource leaks #6039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
https://issues.apache.org/jira/browse/HADOOP-18800
This PR adds a non-negative check for the idle scan duration.
How was this patch tested?
(1) Set
ipc.client.connection.idle-scan-interval.msto-1(2) Run test
org.apache.hadoop.ipc.TestIPC#testSocketLeakThe test fails with an illegal argument exception rather than the assertion error mentioned in the issue.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?