HDFS-17196. Overflow during getDatanodeReadTimeout #6091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Oct 11, 2023
Comment on lines
478
to
+483
| int getDatanodeReadTimeout(int numNodes) { | ||
| final int t = dfsClientConf.getSocketTimeout(); | ||
| return t > 0? HdfsConstants.READ_TIMEOUT_EXTENSION*numNodes + t: 0; | ||
| int readTimeout = HdfsConstants.READ_TIMEOUT_EXTENSION*numNodes + t; | ||
| Preconditions.checkArgument(readTimeout >= 0, | ||
| "Read timeout should be non-negative."); | ||
| return t > 0? readTimeout: 0; |
Member
There was a problem hiding this comment.
should be something like?
int getDatanodeReadTimeout(int numNodes) {
final int t = dfsClientConf.getSocketTimeout();
if (t > 0) {
int readTimeout = HdfsConstants.READ_TIMEOUT_EXTENSION * numNodes + t;
Preconditions.checkArgument(readTimeout >= 0, "Read timeout should be non-negative.");
return readTimeout;
}
return 0;
}
|
💔 -1 overall
This message was automatically generated. |
Member
|
@teamconfx any plans to update? |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Datanode read timeout equals to READ_TIMEOUT_EXTENSION * numNodes +
dfs.client.socket-timeout. A large dfs.client.socket-timeout/numNodes/READ_TIMEOUT_EXTENSION will cause overflow.To reproduce:
dfs.client.socket-timeoutto 2147483646mvn surefire:test -Dtest=org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode#testBlocksRemovedWhileInSafeModeEditsArriveFirstThis PR provides a fix by checking the read timeout calculation is at least 0.
How was this patch tested?
Unit test
For code changes: