-
Couldn't load subscription status.
- Fork 9.1k
HADOOP-19078. Reduce use of javax.ws.rs.core.MediaType #6555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, big diff, though the actual code change is minimal.
other than import placement in some of the test cases, LGTM
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/ContentTypes.java
Outdated
Show resolved
Hide resolved
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/ContentTypes.java
Outdated
Show resolved
Hide resolved
...project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/ExceptionHandler.java
Outdated
Show resolved
Hide resolved
...rn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineReaderClientImpl.java
Outdated
Show resolved
Hide resolved
...p-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineV2ClientImpl.java
Outdated
Show resolved
Hide resolved
| import java.util.concurrent.CancellationException; | ||
|
|
||
| import javax.ws.rs.core.MediaType; | ||
| import javax.ws.rs.core.MultivaluedMap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presumably we will want to cut this too, in future...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I think so but I need to be more research about MultivaluedMap to work out what the alternative is.
.../hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineWriter.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java
Outdated
Show resolved
Hide resolved
...ice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestTimelineWebServices.java
Outdated
Show resolved
Hide resolved
...a/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesACL.java
Show resolved
Hide resolved
24b019c to
54b83fb
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
review comments - mainly import order use ContentTypes in more places use MediaType in timelineservice module Update TestTimelineReaderWebServices.java rework timeline tests fix format issues
fc9e7ee to
5c27e1f
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Description of PR
HADOOP-19078
How was this patch tested?
CI build
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?