HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. #6685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojunxiang2023
force-pushed
the
HDFS-17446
branch
from
0a2ddba to
50f4f68
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
xiaojunxiang2023
force-pushed
the
HDFS-17446
branch
3 times, most recently
from
8bd8147 to
cdd464c
Compare
|
💔 -1 overall
This message was automatically generated. |
xiaojunxiang2023
force-pushed
the
HDFS-17446
branch
from
cdd464c to
3e8161b
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
xiaojunxiang2023
force-pushed
the
HDFS-17446
branch
from
3e8161b to
f8f1869
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@hiwangzhihui, Hi~, please help me review it. |
hiwangzhihui
reviewed
Apr 1, 2024
| subTask.fork(); | ||
| subTaskQueue.add(subTask); | ||
| } else if (isFinalized && ++scanBlockCnt % 10000 == 0) { | ||
| LOG.info((scanBlockCnt - 1) + " blocks (finalize state) have been scanned."); |
Contributor
There was a problem hiding this comment.
Please take care of concurrency issues that lead to inaccurate counting.
Contributor
There was a problem hiding this comment.
The log style is not easy to view.
Contributor
Author
There was a problem hiding this comment.
ok. I will fix it.
Contributor
Author
There was a problem hiding this comment.
The log style is not easy to view.
I have optimize it:
xiaojunxiang2023
force-pushed
the
HDFS-17446
branch
2 times, most recently
from
bc54efb to
150f983
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…ToReplicasMap execution.
xiaojunxiang2023
force-pushed
the
HDFS-17446
branch
from
150f983 to
bc12b7d
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datanodes do not print logs when addToReplicasMap is just started, so we will not be aware of its progress, or even wait up to 4 hours for a large cluster. This is very confusing.
A cluster is as follows:
The optimized result is as follows:
(Because Scan thread is ForkJoinPool, so the printing may be repeated, but it will affect the overall progress of the presentation
)