Skip to content

HADOOP-19719. Wildfly Followup: TestDelegatingSSLSocketFactory #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
+16 −15
Open

HADOOP-19719. Wildfly Followup: TestDelegatingSSLSocketFactory #8071

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6993144
HADOOP-19719. Wildfly Followup: TestDelegatingSSLSocketFactory
steveloughran Nov 10, 2025
d1b7076
HADOOP-19719. Don't look for text (too far down); just exception type.
steveloughran Nov 13, 2025
b72c0fb
HADOOP-19719. cut back on exception chain asserts.
steveloughran Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions ...p-common/src/test/java/org/apache/hadoop/security/ssl/TestDelegatingSSLSocketFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@
package org.apache.hadoop.security.ssl;

import java.io.IOException;
import java.util.Arrays;
import java.security.NoSuchAlgorithmException;

import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Test;

import org.apache.hadoop.util.NativeCodeLoader;
Expand All @@ -34,24 +35,24 @@
public class TestDelegatingSSLSocketFactory {

@Test
public void testOpenSSL() throws IOException {
public void testOpenSSL() {
assumeTrue(NativeCodeLoader.isNativeCodeLoaded(),
"Unable to load native libraries");
assumeTrue(NativeCodeLoader.buildSupportsOpenssl(),
"Build was not compiled with support for OpenSSL");
DelegatingSSLSocketFactory.initializeDefaultFactory(
DelegatingSSLSocketFactory.SSLChannelMode.OpenSSL);
assertThat(DelegatingSSLSocketFactory.getDefaultFactory()
.getProviderName()).contains("openssl");
try {
DelegatingSSLSocketFactory.initializeDefaultFactory(
DelegatingSSLSocketFactory.SSLChannelMode.OpenSSL);
assertThat(DelegatingSSLSocketFactory.getDefaultFactory()
.getProviderName()).contains("openssl");
} catch (IOException e) {
// if this is caused by a wildfly version error, downgrade to an assume
final Throwable cause = e.getCause();
Assertions.assertThat(cause)
.describedAs("Cause of %s: %s", e, cause)
.isInstanceOf(NoSuchAlgorithmException.class);
assumeTrue(false, "wildfly library not compatible with this OS version");
}
}

@Test
public void testJSEENoGCMJava8() throws IOException {
assumeTrue(System.getProperty("java.version").startsWith("1.8"),
"Not running on Java 8");
DelegatingSSLSocketFactory.initializeDefaultFactory(
DelegatingSSLSocketFactory.SSLChannelMode.Default_JSSE);
assertThat(Arrays.stream(DelegatingSSLSocketFactory.getDefaultFactory()
.getSupportedCipherSuites())).noneMatch("GCM"::contains);
}
}