HDFS-17834. Fix invalid HTTP links for DataNodes in IPv6 environment #8081

sunhui233 · 2025-11-12T06:08:22Z

Description of PR

This PR fixes HDFS-17834: HDFS NameNode Web UI generates invalid HTTP links for DataNodes in IPv6 environment.

Problem

The NameNode Web UI incorrectly handles IPv6 addresses in DataNode links:

Fails to encapsulate IPv6 addresses in square brackets [] as required by RFC 2732
Incorrectly parses IPv6 addresses, mistaking parts of the address for port numbers
Generates malformed, unclickable links that don't point to the DataNode's web interface

Solution

Properly wrap IPv6 addresses in square brackets for URL construction
Fix the address parsing logic to correctly separate IPv6 addresses from port numbers
Ensure generated links follow RFC 2732 standards for IPv6 literal addresses in URLs

Example

Before: https://datanodeHostname:30 (invalid)
After: https://[1172:30:0:0:0:0:8a34]:50010 (valid)

How was this patch tested?

Added unit tests for IPv6 address formatting in URL generation
Tested with existing IPv4 addresses to ensure no regression
Manual testing with IPv6 DataNode configurations
Verified generated links are clickable and point to correct DataNode web interfaces

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Note: This PR only contains code changes and no new dependencies were added.

hadoop-yetus · 2025-11-12T07:33:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	7m 6s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-3.4 Compile Tests _
+0 🆗	mvndep	2m 48s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 26s		branch-3.4 passed
+1 💚	shadedclient	51m 58s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	22m 2s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 24s		The patch does not generate ASF License warnings.
		83m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8081/1/artifact/out/Dockerfile
GITHUB PR	#8081
Optional Tests	dupname asflicense shadedclient codespell detsecrets jshint
uname	Linux d0a344ecc87e 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.4 / `53a90bd`
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8081/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-11-12T14:38:34Z

@mynameis180 Since this changes some pages, could you share a few screenshots?

sunhui233 · 2025-11-13T03:07:28Z

@mynameis180 Since this changes some pages, could you share a few screenshots?
before fix:

Hexiaoqiao

Good catch, leave one nit comment inline. FYI.

Hexiaoqiao · 2025-11-17T04:22:59Z

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/router/federationhealth.js

-          var port = n.infoAddr.split(":")[1];
-          var securePort = n.infoSecureAddr.split(":")[1];
+          var infoAddrParts = n.infoAddr.split("]:");
+          var port = "9864";


This static value should be not necessary here. It is better to correct it include the following same definition.

ok，I will remove duplicate variable declaration - The original code declared port twice
remove the hardcoded "9864" assignment as requested

hadoop-yetus · 2025-11-19T04:16:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	7m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-3.4 Compile Tests _
+0 🆗	mvndep	2m 26s		Maven dependency ordering for branch
+1 💚	mvninstall	22m 32s		branch-3.4 passed
+1 💚	shadedclient	43m 47s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 53s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	18m 34s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 23s		The patch does not generate ASF License warnings.
		72m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8081/2/artifact/out/Dockerfile
GITHUB PR	#8081
Optional Tests	dupname asflicense shadedclient codespell detsecrets jshint
uname	Linux a4c44e3d9a4e 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.4 / `fbbb43e`
Max. process+thread count	551 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8081/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

sunhui233 · 2025-11-20T02:03:00Z

@Hexiaoqiao please review again

Hexiaoqiao

LGTM. +1.

Hexiaoqiao · 2025-11-20T08:51:53Z

Committed to branch-3.4. Thanks @mynameis180 for your contribution and @slfan1989 for your reviews.

Hexiaoqiao · 2025-11-20T08:53:13Z

@mynameis180 How about to submit another PR to trunk?

sunhui233 · 2025-11-21T02:01:21Z

@mynameis180 How about to submit another PR to trunk?

ok

Hexiaoqiao reviewed Nov 17, 2025

View reviewed changes

HDFS-17834. Fix invalid HTTP links for DataNodes in IPv6 environment

fbbb43e

sunhui233 force-pushed the HDFS-17834 branch from 53a90bd to fbbb43e Compare November 19, 2025 03:02

Hexiaoqiao approved these changes Nov 20, 2025

View reviewed changes

Hexiaoqiao merged commit 1b06ac1 into apache:branch-3.4 Nov 20, 2025
3 checks passed

HDFS-17834. Fix invalid HTTP links for DataNodes in IPv6 environment #8081

HDFS-17834. Fix invalid HTTP links for DataNodes in IPv6 environment #8081

Conversation

sunhui233 commented Nov 12, 2025

Description of PR

Problem

Solution

Example

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Nov 12, 2025

Uh oh!

slfan1989 commented Nov 12, 2025

Uh oh!

sunhui233 commented Nov 13, 2025

Uh oh!

Hexiaoqiao left a comment

Choose a reason for hiding this comment

Uh oh!

Hexiaoqiao Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

sunhui233 Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Nov 19, 2025

Uh oh!

sunhui233 commented Nov 20, 2025

Uh oh!

Hexiaoqiao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Hexiaoqiao commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hexiaoqiao commented Nov 20, 2025

Uh oh!

sunhui233 commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hexiaoqiao commented Nov 20, 2025 •

edited

Loading