-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11894 clean up file system before and after each state to address order dependency #8083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
18chanp1
wants to merge
1
commit into
apache:trunk
Choose a base branch
from
18chanp1:l2173
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Nov 17, 2025
Contributor
Hexiaoqiao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the extra blank line. Others seems good to me.
042204f to
7864b68
Compare
…s order dependency if other tests are run in between test class.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s order dependency if other tests are run in between test class.
Description of PR
In package org.apache.hadoop.yarn.server.timeline, TestLogInfo test, it is sometimes order dependent if interleaved with other tests from other classes. This perhaps suggests some state pollution. In particular, this affects tests
org.apache.hadoop.yarn.server.timeline.TestLogInfo.testMatchesGroupId
org.apache.hadoop.yarn.server.timeline.TestLogInfo.testParseBrokenEntity
org.apache.hadoop.yarn.server.timeline.TestLogInfo.testParseDomain
org.apache.hadoop.yarn.server.timeline.TestLogInfo.testParseEntity
This was addressed by cleaning the file system created in the test directory
How was this patch tested?
mvn testwas run and all previous tests continue to pass.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?