HDFS-17857. Provide implementation for FaultInjectorFileIoEvents #8104
+518
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
ctubbsii
reviewed
Nov 26, 2025
Comment on lines
+1202
to
+1205
| public static final String DFS_DATANODE_ENABLED_OPS_FILEIO_FAULT_INJECTION_KEY = | ||
| "dfs.datanode.enabled.operations.fileio.fault.injection"; | ||
| public static final String DFS_DATANODE_FILEIO_FAULT_PERCENTAGE_KEY = | ||
| "dfs.datanode.fileio.fault.sampling.percentage"; |
Member
There was a problem hiding this comment.
These three key prefixes are very different for a common set of related properties, and that is a bit confusing, since related properties don't share a common prefix:
dfs.datanode.enable.fileio.fault.*dfs.datanode.enabled.operations.fileio.fault.*dfs.datanode.fileio.fault.*
It would be good if these could be standardized on something... like:
dfs.datanode.fileio.fault.*
Also, is "sampling" the right word here? Isn't it simulating (or injecting), not sampling? It could also just be called "rate".
All three properties could be merged into a single one:
dfs.datanode.fault.injection.fileio=operation1:20%,operation2:5%
Then, a default empty value would imply no fault injection, and the pre-existing property could be obsoleted. The prefix dfs.datanode.fault.injection.* could also be support other kinds of fault injection in the future, rather than just fileio types.
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
This change adds an implementation to FaultInjectorFileIoEvents that responds to related properties. If enabled, then FaultInjectorFileIoEvents will throw an UncheckedIOException for the configured I/O operations at the configured percentage of calls for that operation type.
How was this patch tested?
Patch includes the TestFaultInjectorFileIoEvents unit test and TestDataNodeFileIOFailures test which confirms that exceptions are bubbled up to the HDFS client when a sync operation via
hsync,CreateMode.SYNC_BLOCKanddfs.datanode.synconclosethrow an exception.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?