HBASE-25115 HFilePrettyPrinter can't seek to the row which is the first row of a hfile #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
requested changes
Sep 30, 2020
| shouldScanKeysValues = true; | ||
| } | ||
| } | ||
| if (needSeekToBegin) { |
There was a problem hiding this comment.
Isn't this scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row)) always going to return -1, since it's fabricating a KV with no CF? If so, I guess your logic could be simplified.
There was a problem hiding this comment.
Yes, but only when the row is the first row in hfile, scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row)) return -1
There was a problem hiding this comment.
Gotcha, thanks for clarifying!
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…st row of a hfile
nyl3532016
force-pushed
the
HBASE-25115
branch
from
6870f67
to
e8b8e53
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Oct 2, 2020
virajjasani
pushed a commit
that referenced
this pull request
Oct 4, 2020
…st row of a hfile Closes #2473 Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
Oct 4, 2020
…st row of a hfile Closes #2473 Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…st row of a hfile Closes apache#2473 Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…st row of a hfile (apache#2481) Closes apache#2473 Signed-off-by: stack <stack@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 7de2bb2) Change-Id: Iabb5b40f38f45ba5616f8b883f69cd793ed951f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we seek to first row in hfile, the
firstOnRowwith empty famliy( create byPrivateCellUtil.createFirstOnRow) is smaller than any row in hfile, So we need to seekTo the hfile beginning and do the seek