Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword() #3408

Merged
merged 1 commit into from
Jun 23, 2021
Merged

HBASE-26019 Remove reflections used in HBaseConfiguration.getPassword() #3408

merged 1 commit into from
Jun 23, 2021

Conversation

jojochuang
Copy link
Contributor

No description provided.

@jojochuang
Remove the reflection and call Configuration.getPassword() directly.
c8539c9 
Change-Id: I2fe146d07714ed73eea4e9dd57a43a54b44e27c8
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 41s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 59s master passed
+1 💚 compile 0m 24s master passed
+1 💚 shadedjars 8m 19s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 41s the patch passed
+1 💚 compile 0m 24s the patch passed
+1 💚 javac 0m 24s the patch passed
+1 💚 shadedjars 8m 9s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s the patch passed
_ Other Tests _
+1 💚 unit 1m 48s hbase-common in the patch passed.
35m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3408
Optional Tests javac javadoc unit shadedjars compile
uname Linux bda68e58ce75 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9f4177f
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/testReport/
Max. process+thread count 344 (vs. ulimit of 30000)
modules C: hbase-common U: hbase-common
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 39s master passed
+1 💚 compile 0m 27s master passed
+1 💚 shadedjars 9m 35s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 29s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 31s the patch passed
+1 💚 compile 0m 29s the patch passed
+1 💚 javac 0m 29s the patch passed
+1 💚 shadedjars 9m 33s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 26s the patch passed
_ Other Tests _
+1 💚 unit 2m 38s hbase-common in the patch passed.
37m 42s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3408
Optional Tests javac javadoc unit shadedjars compile
uname Linux be8fd7ef25f0 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9f4177f
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/testReport/
Max. process+thread count 202 (vs. ulimit of 30000)
modules C: hbase-common U: hbase-common
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 0s master passed
+1 💚 compile 0m 50s master passed
+1 💚 checkstyle 0m 26s master passed
+1 💚 spotbugs 0m 47s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 36s the patch passed
+1 💚 compile 0m 47s the patch passed
+1 💚 javac 0m 47s the patch passed
-0 ⚠️ checkstyle 0m 23s hbase-common: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 18m 11s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 0m 54s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
38m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3408
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux ad1252c85398 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9f4177f
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-common U: hbase-common
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3408/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

tomscut
tomscut approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@tomscut tomscut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jojochuang
Copy link
Contributor Author

Thanks a lot for the review, @wchevreuil @virajjasani and @tomscut . I'll merge it.

@jojochuang jojochuang merged commit 9a324bd into apache:master Jun 23, 2021
asfgit pushed a commit that referenced this pull request Jun 23, 2021
@jojochuang
Remove the reflection and call Configuration.getPassword() directly. (#…
669ff7b 
…3408)

Reviewed-by: Viraj Jasani <vjasani@apache.org>
Reviewed-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: litao <tomleescut@gmail.com>
(cherry picked from commit 9a324bd)
petersomogyi added a commit that referenced this pull request Jun 23, 2021
@petersomogyi
Revert "Remove the reflection and call Configuration.getPassword() di…
1978fae 
…rectly. (#3408)"

This reverts commit 669ff7b.
petersomogyi pushed a commit that referenced this pull request Jun 23, 2021
@jojochuang @petersomogyi
HBASE-26019 Remove the reflection and call Configuration.getPassword(…
e3eb760 
…) directly. (#3408)

Reviewed-by: Viraj Jasani <vjasani@apache.org>
Reviewed-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: litao <tomleescut@gmail.com>
petersomogyi added a commit that referenced this pull request Jun 23, 2021
@petersomogyi
Revert "Remove the reflection and call Configuration.getPassword() di…
1a9ddb6 
…rectly. (#3408)"

This reverts commit 9a324bd.
petersomogyi pushed a commit that referenced this pull request Jun 23, 2021
@jojochuang @petersomogyi
HBASE-26019 Remove the reflection and call Configuration.getPassword(…
cb247f9 
…) directly. (#3408)

Reviewed-by: Viraj Jasani <vjasani@apache.org>
Reviewed-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: litao <tomleescut@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

@virajjasani virajjasani virajjasani approved these changes

@tomscut tomscut tomscut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jojochuang @Apache-HBase @wchevreuil @virajjasani @tomscut