HBASE-26458 Update Snapshot TTL doc #3852

joswiatek · 2021-11-16T22:51:15Z

See JIRA for detail: https://issues.apache.org/jira/browse/HBASE-26458

The bug is that the default value for TTL when no explicit TTL is -1, but the snapshot validation that applies hbase.master.snapshot.ttl looks for 0. Both should use -1, and share the value in a constant.

Apache-HBase · 2021-11-16T23:52:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 1s	master passed
+1 💚	compile	5m 1s	master passed
+1 💚	checkstyle	1m 58s	master passed
+1 💚	spotbugs	3m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	compile	4m 52s	the patch passed
+1 💚	javac	4m 52s	the patch passed
+1 💚	checkstyle	1m 54s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 26s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	4m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 41s	The patch does not generate ASF License warnings.
		59m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux b6a16d707873 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1c47f80`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-17T01:50:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 42s	master passed
+1 💚	compile	2m 13s	master passed
+1 💚	shadedjars	8m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	2m 12s	the patch passed
+1 💚	javac	2m 12s	the patch passed
+1 💚	shadedjars	8m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 2s	hbase-common in the patch passed.
+1 💚	unit	1m 32s	hbase-client in the patch passed.
+1 💚	unit	137m 33s	hbase-server in the patch passed.
		178m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux de2c7bf6c6fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1c47f80`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/1/testReport/
Max. process+thread count	4247 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Good catch. Thanks for finding this and fix it.

I think in the release note, we'b better mention clearly about the broken behavior in the past, and how it is changed after this fix. At least this is a behavior change, we need to let users clearly know the side efffect.

Apache-HBase · 2021-11-17T03:06:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 38s	master passed
+1 💚	compile	1m 57s	master passed
+1 💚	shadedjars	9m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 24s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 16s	the patch passed
+1 💚	compile	1m 57s	the patch passed
+1 💚	javac	1m 57s	the patch passed
+1 💚	shadedjars	9m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 56s	hbase-common in the patch passed.
+1 💚	unit	1m 35s	hbase-client in the patch passed.
+1 💚	unit	213m 2s	hbase-server in the patch passed.
		254m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 021f437fa253 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1c47f80`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/1/testReport/
Max. process+thread count	3918 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1, thanks @joswiatek

virajjasani · 2021-11-17T06:43:47Z

@joswiatek Since attached patches over the Jira no longer triggers QA, can you once create PRs for branch-2 and branch-1? Once we have the QA, all PRs will be merged and branch-2 change can be cherry-picked to 2.4 and 2.3 release branches.

I think in the release note, we'b better mention clearly about the broken behavior in the past, and how it is changed after this fix.

+1

virajjasani · 2021-11-17T09:41:31Z

Oh wait, now I recall why client and server side have different default TTL values.

Until things get more clear

virajjasani · 2021-11-17T09:57:38Z

SnapshotDescription is used at client side to store TTL value. Now, the default value is -1 if not specified.
Now, while creating snapshot, SnapshotDescription is converted to SnapshotProtos.SnapshotDescription and here is the logic for TTL conversion:

    if (snapshotDesc.getTtl() != -1L &&
        snapshotDesc.getTtl() < TimeUnit.MILLISECONDS.toSeconds(Long.MAX_VALUE)) {
      builder.setTtl(snapshotDesc.getTtl());
    }

Hence, by default -1 won't be set in SnapshotProtos.SnapshotDescription and the default value of SnapshotProtos.SnapshotDescription will be used:

message SnapshotDescription {
  required string name = 1;
  optional string table = 2; // not needed for delete, but checked for in taking snapshot
  optional int64 creation_time = 3 [default = 0];
  enum Type {
    DISABLED = 0;
    FLUSH = 1;
    SKIPFLUSH = 2;
  }
  optional Type type = 4 [default = FLUSH];
  optional int32 version = 5;
  optional string owner = 6;
  optional UsersAndPermissions users_and_permissions = 7;
  optional int64 ttl = 8 [default = 0];
  optional int64 max_file_size = 9 [default = 0];
}

As per this proto message, default value of TTL for SnapshotProtos.SnapshotDescription would be 0.
Hence, as per this logic, 0 is NO_SNAPSHOT_TTL_SPECIFIED and default TTL will be used that we set with config hbase.master.snapshot.ttl.

    long ttl = snapshot.getTtl();
    // set default ttl(sec) if it is not set already or the value is out of the range
    if (ttl == SnapshotDescriptionUtils.NO_SNAPSHOT_TTL_SPECIFIED ||
        ttl > TimeUnit.MILLISECONDS.toSeconds(Long.MAX_VALUE)) {
      final long defaultSnapshotTtl = conf.getLong(HConstants.DEFAULT_SNAPSHOT_TTL_CONFIG_KEY,
          HConstants.DEFAULT_SNAPSHOT_TTL);
      if (LOG.isDebugEnabled()) {
        LOG.debug("Snapshot current TTL value: {} resetting it to default value: {}", ttl,
            defaultSnapshotTtl);
      }
      ttl = defaultSnapshotTtl;
    }
    SnapshotDescription.Builder builder = snapshot.toBuilder();
    builder.setTtl(ttl);
    snapshot = builder.build();

@joswiatek No specifying TTL while creating snapshot should result in using default TTL as specified by hbase.master.snapshot.ttl. For the testing purpose, value of hbase.master.cleaner.snapshot.interval can be reduced to test this scenario so that SnapshotCleanerChore would be able to delete expired snapshots.

Also, here is the SnapshotCleanerChore logic that would delete only snapshots with value > 0 and value < Long.MAX:

        long snapshotTtl = snapshotDescription.getTtl();
        /*
         * Backward compatibility after the patch deployment on HMaster
         * Any snapshot with ttl 0 is to be considered as snapshot to keep FOREVER
         * Default ttl value specified by {@HConstants.DEFAULT_SNAPSHOT_TTL}
         */
        if (snapshotCreatedTime > 0 && snapshotTtl > 0 &&
                snapshotTtl < TimeUnit.MILLISECONDS.toSeconds(Long.MAX_VALUE)) {
          long currentTime = EnvironmentEdgeManager.currentTime();
          if ((snapshotCreatedTime + TimeUnit.SECONDS.toMillis(snapshotTtl)) < currentTime) {
            LOG.info("Event: {} Name: {}, CreatedTime: {}, TTL: {}, currentTime: {}",
                    DELETE_SNAPSHOT_EVENT, snapshotDescription.getName(), snapshotCreatedTime,
                    snapshotTtl, currentTime);
            deleteExpiredSnapshot(snapshotDescription);
          }
        }

I am confident that the current logic should work fine for the case where client doesn't specify snapshot resulting into using TTL specified by config hbase.master.snapshot.ttl.

virajjasani · 2021-11-17T10:11:19Z

The only case that might require behaviour change is when user specifies TTL 0:

> snapshot 'mytable', 'snapshot1234', {TTL => 0}

This snapshot would also be eligible to be deleted as per config hbase.master.snapshot.ttl because this config is applicable at entire cluster.

If use specifies TTL value less than -1, then that snapshot will never be deleted based on TTL.
Here is the current behaviour:

If client wants to create specific snapshot that should live forever regardless of hbase.master.snapshot.ttl config value, then they should specify TTL < -1. e.g snapshot 'mytable', 'snapshot1234', {TTL => -2}
If we don't want to enable TTL at entire cluster level, no need of any config change because the default value of hbase.master.snapshot.ttl is 0, which represents TTL Forever at server side.

It's also important to note that SnapshotCleanerChore can be enabled/disabled using shell command: snapshot_cleanup_switch. More details in the section Enable/Disable Snapshot Auto Cleanup on running cluster here

virajjasani

If client wants to create specific snapshot that should live forever regardless of hbase.master.snapshot.ttl config value, then they should specify TTL < -1. e.g snapshot 'mytable', 'snapshot1234', {TTL => -2}

If we don't want to enable TTL at entire cluster level, no need of any config change because the default value of hbase.master.snapshot.ttl is 0, which represents TTL Forever at server side.

I think we need these 2 points to be clearly mentioned in the HBase book.
As for the PR, we can't make this change because it requires changing proto and changing default value of proto is not compatible change for cluster already utilizing this feature.

virajjasani · 2021-11-17T11:01:21Z

I just tested on the latest HEAD of master branch.

Configs:

  <property>
    <name>hbase.master.cleaner.snapshot.interval</name>
    <value>10000</value>
  </property>

Shell commands and respective outputs:

snapshot 't1', 's2'
Took 2.1034 seconds

snapshot 't1', 's3', {TTL => -2}
Took 1.0925 seconds
=> [{"TTL"=>-2}]

snapshot 't1', 's1', {TTL => 5}
Took 2.1023 seconds
=> [{"TTL"=>5}]

After 5sec, the snapshot was gone.

Configs:

  <property>
    <name>hbase.master.cleaner.snapshot.interval</name>
    <value>10000</value>
  </property>
  <property>
    <name>hbase.master.snapshot.ttl</name>
    <value>20</value>
  </property>

Shell commands and respective outputs:

snapshot 't1', 's4'
Took 2.7291 seconds

Snapshot 's4' gets created with TTL 20 sec because of config hbase.master.snapshot.ttl:

After 20s, it was gone:

snapshot 't1', 's5', {TTL => -10}
Took 2.1079 seconds
=> [{"TTL"=>-10}]

TTL with negative values < -1, will stay forever regardless of any server side config changes.
TTL with positive values will be gone after TTL expires.
Snapshot created without specifying TTL will always have TTL value represented by config hbase.master.snapshot.ttl.
From client side, TTL values 0 or -1 should not be provided because they will be treated as snapshot without TTL (same as point 3 above) and hence will represent TTL as per value represented by config hbase.master.snapshot.ttl.

I think we have doc with details of server side configs hbase.master.cleaner.snapshot.interval and hbase.master.snapshot.ttl. From client viewpoint, we should mention above 4 points.

Also, it's bit complex to resolve point 4 completely because in order to represent value as default TTL, we will have to either sacrifice the meaning of 0 or -1 (if not both) in the best case. I think as long as the above mentioned points are taken care of, we should not see any TTL related issues.
Note: updating default value in proto message is considered as incompatible change. Even if we want to present only either 0 or 1 as default TTL, we will need changes to proto definition and be careful of the issues that could arise from rolling upgrade. Given the incompatibility cost, I believe we should rather follow the behaviour mentioned in above 4 points :( Thoughts?

joswiatek · 2021-11-17T22:50:21Z

Thank you for digging into this! I totally missed the protobuf component. It is great to see this is working on master HEAD.

After reviewing these new protobuf details, I think the behavior where hbase.master.snapshot.ttl is ignored is only present on branch-1. On branch-1, the builder just directly takes the value from the snapshotProps, so -1 is actually sent and it does not match NO_SNAPSHOT_TTL_SPECIFIED, and the config is not applied. See here.

    SnapshotDescription.Builder builder = SnapshotDescription.newBuilder();
    builder.setTable(tableName.getNameAsString());
    builder.setName(snapshotName);
    builder.setType(type);
    builder.setTtl(getTtlFromSnapshotProps(snapshotProps));
    snapshot(builder.build());

On a branch-1 build, I do see snapshots being created with a -1 TTL when the default config is set.

Configs:

  <property>
    <name>hbase.master.snapshot.ttl</name>
    <value>600</value>
  </property>

Shell commands and outputs

snapshot 't1', 's1'

Snapshot is actually created with a TTL of -1 instead of 600

updating default value in proto message is considered as incompatible change

I am not experienced with protobuf, so I will take your word about defaults here. One question: is changing the logic around building the protobuf also an incompatible change? If we can update the TTL conversion logic to allow for sending -1, then the code changes in this PR will make sense and allow for the currently documented behavior to be fulfilled.

If that's not possible, I can update this PR with the clarifying doc changes as suggested.

This reverts commit 3375f2b.

Apache-HBase · 2021-11-18T19:57:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 29s	master passed
+1 💚	compile	9m 54s	master passed
+1 💚	checkstyle	2m 12s	master passed
+0 🆗	refguide	3m 47s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	15m 28s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 35s	the patch passed
+1 💚	compile	10m 21s	the patch passed
+1 💚	javac	10m 21s	the patch passed
+1 💚	checkstyle	2m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	4m 5s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	20m 49s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	14m 41s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 56s	The patch does not generate ASF License warnings.
		104m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide
uname	Linux 9d17c07c44f8 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b2571df`
Default Java	AdoptOpenJDK-1.8.0_282-b08
refguide	https://nightlies.apache.org/hbase/HBase/HBase-PreCommit-GitHub-PR/PR-3852/2/yetus-general-check/output/branch-site/book.html
refguide	https://nightlies.apache.org/hbase/HBase/HBase-PreCommit-GitHub-PR/PR-3852/2/yetus-general-check/output/patch-site/book.html
Max. process+thread count	141 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-18T22:26:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 50s	master passed
+1 💚	compile	3m 13s	master passed
+1 💚	shadedjars	8m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	3m 12s	the patch passed
+1 💚	javac	3m 12s	the patch passed
+1 💚	shadedjars	8m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	207m 40s	root in the patch passed.
		253m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4770328ba33d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b2571df`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/2/testReport/
Max. process+thread count	7568 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-19T02:08:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 19s	master passed
+1 💚	compile	3m 0s	master passed
+1 💚	shadedjars	9m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 15s	the patch passed
+1 💚	compile	3m 0s	the patch passed
+1 💚	javac	3m 0s	the patch passed
+1 💚	shadedjars	9m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	425m 50s	root in the patch passed.
		475m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8d50511c12e6 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b2571df`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/2/testReport/
Max. process+thread count	3927 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

Left minor comment, +1 otherwise.

src/main/asciidoc/_chapters/ops_mgt.adoc

joswiatek · 2021-11-22T22:35:11Z

I've included the additional doc suggestions, thanks for the review y'all

Apache-HBase · 2021-11-23T00:12:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 2s	master passed
+1 💚	compile	9m 23s	master passed
+1 💚	checkstyle	2m 20s	master passed
+0 🆗	refguide	3m 31s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	15m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	8m 54s	the patch passed
+1 💚	javac	8m 54s	the patch passed
+1 💚	checkstyle	1m 56s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	3m 25s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	19m 14s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	14m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 56s	The patch does not generate ASF License warnings.
		97m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide
uname	Linux ab9684e32957 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
refguide	https://nightlies.apache.org/hbase/HBase/HBase-PreCommit-GitHub-PR/PR-3852/3/yetus-general-check/output/branch-site/book.html
refguide	https://nightlies.apache.org/hbase/HBase/HBase-PreCommit-GitHub-PR/PR-3852/3/yetus-general-check/output/patch-site/book.html
Max. process+thread count	141 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-23T03:00:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 6s	master passed
+1 💚	compile	3m 31s	master passed
+1 💚	shadedjars	9m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 2s	the patch passed
+1 💚	compile	3m 36s	the patch passed
+1 💚	javac	3m 36s	the patch passed
+1 💚	shadedjars	9m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	213m 21s	root in the patch passed.
		264m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 08b0618e844b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/3/testReport/
Max. process+thread count	6845 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-23T07:51:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 17s	master passed
+1 💚	compile	3m 33s	master passed
+1 💚	shadedjars	10m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 1s	the patch passed
+1 💚	compile	3m 31s	the patch passed
+1 💚	javac	3m 31s	the patch passed
+1 💚	shadedjars	10m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	505m 5s	root in the patch passed.
		556m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3852
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 39cbe1f7cbd2 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/3/testReport/
Max. process+thread count	4002 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3852/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-11-23T10:54:33Z

Thanks @joswiatek. Left one comment on #3857 for branch-1 backport. Once done, will merge both PRs.

HBASE-22458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting

3375f2b

Apache9 approved these changes Nov 17, 2021

View reviewed changes

virajjasani previously approved these changes Nov 17, 2021

View reviewed changes

virajjasani requested changes Nov 17, 2021

View reviewed changes

virajjasani changed the title ~~HBASE-22458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting~~ HBASE-26458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting Nov 17, 2021

jswiatek-salesforce added 2 commits November 18, 2021 09:22

Revert "HBASE-22458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting"

197aec5

This reverts commit 3375f2b.

HBASE-26458 Update snapshot doc

cb6e703

joswiatek mentioned this pull request Nov 18, 2021

HBASE-26458 Update snapshot doc #3856

Closed

joswiatek changed the title ~~HBASE-26458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting~~ HBASE-26458 Update Snapshot TTL doc Nov 18, 2021

virajjasani approved these changes Nov 19, 2021

View reviewed changes

src/main/asciidoc/_chapters/ops_mgt.adoc Show resolved Hide resolved

Apache9 approved these changes Nov 21, 2021

View reviewed changes

HBASE-26458 Include additional doc suggestions

c3e49e5

virajjasani merged commit e702aae into apache:master Nov 24, 2021

joswiatek deleted the hbase-26458 branch November 29, 2021 19:36

HBASE-26458 Update Snapshot TTL doc #3852

HBASE-26458 Update Snapshot TTL doc #3852

Uh oh!

Conversation

joswiatek commented Nov 16, 2021

Uh oh!

Apache-HBase commented Nov 16, 2021

Uh oh!

Apache-HBase commented Nov 17, 2021

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Nov 17, 2021

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Nov 17, 2021

Uh oh!

virajjasani commented Nov 17, 2021

Uh oh!

virajjasani commented Nov 17, 2021

Uh oh!

virajjasani commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virajjasani left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joswiatek commented Nov 17, 2021

Configs:

Shell commands and outputs

Uh oh!

Apache-HBase commented Nov 18, 2021

Uh oh!

Apache-HBase commented Nov 18, 2021

Uh oh!

Apache-HBase commented Nov 19, 2021

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joswiatek commented Nov 22, 2021

Uh oh!

Apache-HBase commented Nov 23, 2021

Uh oh!

Apache-HBase commented Nov 23, 2021

Uh oh!

Apache-HBase commented Nov 23, 2021

Uh oh!

virajjasani commented Nov 23, 2021

Uh oh!

Uh oh!

virajjasani commented Nov 17, 2021 •

edited

Loading

virajjasani left a comment •

edited

Loading

virajjasani commented Nov 17, 2021 •

edited

Loading