HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest #990

HorizonNet · 2020-01-05T23:36:24Z

No description provided.

…e-rest

Apache-HBase · 2020-01-06T00:43:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 35s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 12s	master passed
+1 💚	compile	0m 44s	master passed
+1 💚	checkstyle	2m 32s	master passed
+1 💚	shadedjars	4m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	master passed
+0 🆗	spotbugs	0m 53s	Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗	findbugs	0m 16s	branch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 59s	the patch passed
+1 💚	compile	0m 45s	the patch passed
+1 💚	javac	0m 45s	the patch passed
+1 💚	checkstyle	2m 32s	root: The patch generated 0 new + 0 unchanged - 168 fixed = 0 total (was 168)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	shadedjars	4m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 50s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 36s	the patch passed
+0 🆗	findbugs	0m 14s	hbase-checkstyle has no data from findbugs
		_ Other Tests _
+1 💚	unit	0m 13s	hbase-checkstyle in the patch passed.
+1 💚	unit	4m 18s	hbase-rest in the patch passed.
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		58m 38s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/1/artifact/out/Dockerfile
GITHUB PR	#990
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
uname	Linux 2ea2ec8fa945 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-990/out/precommit/personality/provided.sh
git revision	master / `ab97665`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/1/testReport/
Max. process+thread count	1911 (vs. ulimit of 10000)
modules	C: hbase-checkstyle hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2020-01-06T08:43:20Z

hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java

+            perClientRows / 10))) + ", perClientRunRows=" + (perClientRows / 10) + ", totalRows="
+            + this.R + ", clients=" + this.N + ", flushCommits=" + this.flushCommits
+            + ", writeToWAL=" + this.writeToWAL + ", useTags=" + this.useTags + ", noOfTags="
+            + this.noOfTags;


Good to use StringBuilder may be?

Updated the patch to use StringBuilder instead of String at this one.

Apache-HBase · 2020-01-07T10:05:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 42s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	checkstyle	2m 44s	master passed
+1 💚	shadedjars	4m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
+0 🆗	spotbugs	0m 55s	Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗	findbugs	0m 17s	branch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
-0 ⚠️	patch	1m 9s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 6s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	checkstyle	2m 47s	root: The patch generated 0 new + 0 unchanged - 168 fixed = 0 total (was 168)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	shadedjars	4m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 44s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 36s	the patch passed
+0 🆗	findbugs	0m 14s	hbase-checkstyle has no data from findbugs
		_ Other Tests _
+1 💚	unit	0m 14s	hbase-checkstyle in the patch passed.
+1 💚	unit	4m 16s	hbase-rest in the patch passed.
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		59m 46s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/2/artifact/out/Dockerfile
GITHUB PR	#990
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
uname	Linux 5f13f4516290 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-990/out/precommit/personality/provided.sh
git revision	master / `1eafba5`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/2/testReport/
Max. process+thread count	1976 (vs. ulimit of 10000)
modules	C: hbase-checkstyle hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Apache-HBase · 2020-01-08T10:51:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 30s	master passed
+1 💚	compile	0m 44s	master passed
+1 💚	checkstyle	2m 40s	master passed
+1 💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
+0 🆗	spotbugs	0m 55s	Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗	findbugs	0m 16s	branch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
-0 ⚠️	patch	1m 9s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 7s	the patch passed
+1 💚	compile	0m 43s	the patch passed
+1 💚	javac	0m 43s	the patch passed
+1 💚	checkstyle	2m 28s	root: The patch generated 0 new + 0 unchanged - 168 fixed = 0 total (was 168)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	shadedjars	4m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	16m 38s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 36s	the patch passed
+0 🆗	findbugs	0m 13s	hbase-checkstyle has no data from findbugs
		_ Other Tests _
+1 💚	unit	0m 14s	hbase-checkstyle in the patch passed.
+1 💚	unit	4m 57s	hbase-rest in the patch passed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		61m 15s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/3/artifact/out/Dockerfile
GITHUB PR	#990
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
uname	Linux 587641fe9688 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-990/out/precommit/personality/provided.sh
git revision	master / `5a7c944`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/3/testReport/
Max. process+thread count	1939 (vs. ulimit of 10000)
modules	C: hbase-checkstyle hbase-rest U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HBASE-23646 Resolved remaining Checkstyle violations in tests of hbas…

6f3da9e

…e-rest

HorizonNet added the enhancement label Jan 5, 2020

virajjasani approved these changes Jan 6, 2020

View reviewed changes

Merge branch 'master' into HBASE-23646

0042dea

HBASE-23646 Moved from String to StringBuilder

a0c0821

virajjasani approved these changes Jan 8, 2020

View reviewed changes

HorizonNet merged commit 0a9e1f8 into apache:master Jan 11, 2020

HorizonNet deleted the HBASE-23646 branch January 11, 2020 20:09

HorizonNet mentioned this pull request Jan 12, 2020

HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest #1025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest #990

HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest #990

Uh oh!

HorizonNet commented Jan 5, 2020

Uh oh!

Apache-HBase commented Jan 6, 2020

Uh oh!

virajjasani Jan 6, 2020

Uh oh!

HorizonNet Jan 8, 2020

Uh oh!

Apache-HBase commented Jan 7, 2020

Uh oh!

virajjasani left a comment

Uh oh!

Apache-HBase commented Jan 8, 2020

Uh oh!

Uh oh!

HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest #990

HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest #990

Uh oh!

Conversation

HorizonNet commented Jan 5, 2020

Uh oh!

Apache-HBase commented Jan 6, 2020

Uh oh!

virajjasani Jan 6, 2020

Choose a reason for hiding this comment

Uh oh!

HorizonNet Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 7, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 8, 2020

Uh oh!

Uh oh!