HIVE-23433 : Add Deny Policy on Replicated Database #1016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasha
force-pushed
the
HIVE-23433
branch
3 times, most recently
from
2340c4f to
9513679
Compare
pkumarsinha
reviewed
May 18, 2020
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/RangerLoadTask.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java
Outdated
Show resolved
Hide resolved
| Mockito.when(conf.getVar(REPL_RANGER_SERVICE_NAME)).thenReturn("hive"); | ||
| Path rangerDumpPath = new Path("/tmp"); | ||
| Mockito.when(work.getCurrentDumpPath()).thenReturn(rangerDumpPath); | ||
| mockClient.saveRangerPoliciesToFile(rangerPolicyList, |
Contributor
There was a problem hiding this comment.
Is this line needed? you anyway returning policyList on readRangerPoliciesFromJsonFile call: 178
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ranger/RangerRestClientImpl.java
Outdated
Show resolved
Hide resolved
pkumarsinha
reviewed
May 19, 2020
| denyExceptionsPolicyItem.setAccesses(denyExceptionsPolicyItemAccesses); | ||
| denyExceptionsItemsForBeaconUser.add(denyExceptionsPolicyItem); | ||
| List<String> denyExceptionsPolicyItemsUsers = new ArrayList<String>(); | ||
| denyExceptionsPolicyItemsUsers.add("hive"); |
Contributor
There was a problem hiding this comment.
Shouldn't it be hive service user and obtained from conf?
| denyRangerPolicy.setResources(rangerPolicyResourceMap); | ||
|
|
||
| List<String> accessTypes = new ArrayList<>(); | ||
| accessTypes.addAll(Arrays.asList("create", "update", "drop", "alter", "index", "lock", "write", "ReplAdmin")); |
Contributor
There was a problem hiding this comment.
Don't need to do addAll. You can directly use List accessTypes = Arrays.asList
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.