Skip to content

Conversation

@ShubhamChaurasia
Copy link
Contributor

The issue with order by in llap external client is described in https://issues.apache.org/jira/browse/HIVE-25159

What changes were proposed in this pull request?

To resolve the above issue, we propose removing of order by handling in the llap external client library and let the clients do it at their end.

Why are the changes needed?

  1. These changes are needed to make llap external client queries more performant, earlier they used to generate only a single split for order by queries.
  2. Removing order by support also helps us to get rid of exception arising to due false detection of order by clause (it was specific to spark-llap and was done for that only).

Does this PR introduce any user-facing change?

It removes a config - hive.llap.external.splits.order.by.force.single.split

How was this patch tested?

Through existing unit tests

  • org.apache.hive.jdbc.TestJdbcGenericUDTFGetSplits
  • org.apache.hive.jdbc.TestJdbcGenericUDTFGetSplits2

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Jul 31, 2021
@github-actions github-actions bot closed this Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants