Skip to content

HIVE-26985: Create a trackable hive configuration object #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

HIVE-26985: Create a trackable hive configuration object #4002

wants to merge 6 commits into from

Conversation

@abstractdog
Copy link
Contributor

@abstractdog abstractdog commented Jan 31, 2023

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@abstractdog abstractdog changed the title Hive 26985 HIVE-26985: Create a trackable hive configuration object Jan 31, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kgyrtkirk
kgyrtkirk requested changes Feb 2, 2023
View reviewed changes
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* @deprecated This method will become private eventually; Use {@link #create()} instead.
*/
@Deprecated
protected HiveConf() {
Copy link
Member

@kgyrtkirk kgyrtkirk Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are other options than making HiveConf protected - and I don't think its worth to break all 3rd party extensions for a rarely used debug feature (-1)

https://issues.apache.org/jira/browse/HIVE-26985?focusedCommentId=17683330&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17683330

Copy link
Contributor Author

@abstractdog abstractdog Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for the comment, actually this codepath is just a dependency (before maybe merging HIVE-26984), can we discuss the constuctor related stuff on #3983?

Copy link
Member

@kgyrtkirk kgyrtkirk Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure; I've copied almost the same message to other places... :)

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Apr 4, 2023
@github-actions github-actions bot closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgyrtkirk kgyrtkirk kgyrtkirk requested changes

Assignees

No one assigned

Labels

stale tests failed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abstractdog @kgyrtkirk