Skip to content

Conversation

@uncleGen
Copy link

@uncleGen uncleGen commented Feb 13, 2023

What changes were proposed in this pull request?

constant field will be wrongly propagated in grouping sets.

Why are the changes needed?

This bug will produce wrong result, reproduce it:

create table tb1 (key string, value string);

insert into tb1 values("a", "b");

with mid1 as (
    select 'test_value' as test_field, * from tb1
)
select key, nvl(test_field, 'default_test_value')
from mid1 group by key, test_field
grouping sets(key, test_field, (key, test_field));

Does this PR introduce any user-facing change?

No

How was this patch tested?

add ut

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Apr 15, 2023
@github-actions github-actions bot closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants