HIVE-27103: Fix thrift compilation warnings on drop_dataconnector() #4080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiga-huang
force-pushed
the
fix-thrift-warning
branch
from
88d15a3 to
a3711f8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dengzhhu653
approved these changes
Mar 2, 2023
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix thrift compilation warnings due to missing argument indexes in drop_dataconnector()
Why are the changes needed?
Lots of compilation warnings show up when compiling hive_metastore.thrift.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Compiled locally and verified the warnings disappeared.