-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-27208: Iceberg: Add support for rename table. #4185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zhangbutao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (non-binding)
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
Show resolved
Hide resolved
...-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java
Outdated
Show resolved
Hide resolved
...astore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
Outdated
Show resolved
Hide resolved
aturoczy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being problematic.
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
Outdated
Show resolved
Hide resolved
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
Show resolved
Hide resolved
...-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java
Outdated
Show resolved
Hide resolved
deniskuzZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending tests + minor comments
|
Kudos, SonarCloud Quality Gate passed! |
…ush Saxena, reviewed by Denys Kuzmenko, Butao Zhang)
…ush Saxena, reviewed by Denys Kuzmenko, Butao Zhang)
…ush Saxena, reviewed by Denys Kuzmenko, Butao Zhang)
…ush Saxena, reviewed by Denys Kuzmenko, Butao Zhang)








What changes were proposed in this pull request?
Added support for Rename command for Iceberg tables.
Why are the changes needed?
To support rename queries for Iceberg tables
Does this PR introduce any user-facing change?
Yes, Rename queries can be used for iceberg tables.
How was this patch tested?
UT