HIVE-27258: Remove usage of Splitter.splitToList in HiveMetaStoreClient HTTP client #4227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junlinzeng-db
approved these changes
Apr 12, 2023
Contributor
junlinzeng-db
left a comment
junlinzeng-db
left a comment
There was a problem hiding this comment.
let's also remove the import of the Splitter? +1
kgyrtkirk
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
|
Kudos, SonarCloud Quality Gate passed!
|
dengzhhu653
approved these changes
Apr 13, 2023
Contributor
Author
|
Merged into master. Thanks for the review @junlinzeng-db @dengzhhu653 |
subhasisgorai
pushed a commit
to subhasisgorai/hive
that referenced
this pull request
Apr 14, 2023
…nt HTTP client (Vihang Karajgaonkar, reviewed by Junlin Zeng, Zhihua Deng) (apache#4227)
henrib
pushed a commit
to henrib/hive
that referenced
this pull request
Apr 24, 2023
…nt HTTP client (Vihang Karajgaonkar, reviewed by Junlin Zeng, Zhihua Deng) (apache#4227)
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…nt HTTP client (Vihang Karajgaonkar, reviewed by Junlin Zeng, Zhihua Deng) (apache#4227)
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…nt HTTP client (Vihang Karajgaonkar, reviewed by Junlin Zeng, Zhihua Deng) (apache#4227)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the call Splitter.splitToList from the metastore HTTP client and replaces it with a simple split call.
Why are the changes needed?
Some open source distributions have a different guava version which do not have this Splitter API. In such distributions the standalone hive metastore client code fails.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests cover this change.