Skip to content

Conversation

@InvisibleProgrammer
Copy link
Contributor

What changes were proposed in this pull request?

ObjectCache set up for Iceber CLI drivers (both for positive and negative)

Why are the changes needed?

Qtests failed if they had a limit clause.
Example:

create table icebergtable (id int, name string) stored by iceberg stored as parquet;

insert into icebergtable values (1, 'Joe'), (2, 'Jack');

select * from icebergtable limit 1;

Does this PR introduce any user-facing change?

No

How was this patch tested?

With QTests

@aturoczy
Copy link

LGTM

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abstractdog abstractdog changed the title HIVE-27272 - Fix limit clause issue for iceberg qtests HIVE-27272: Fix limit clause issue for iceberg qtests Apr 21, 2023
@ayushtkn ayushtkn merged commit 5c85b56 into apache:master Apr 21, 2023
@InvisibleProgrammer InvisibleProgrammer deleted the HIVE-27272 branch April 21, 2023 09:20
henrib pushed a commit to henrib/hive that referenced this pull request Apr 24, 2023
yeahyung pushed a commit to yeahyung/hive that referenced this pull request Jul 20, 2023
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants