HIVE-26982 Fix for Select * from a table containing timestamp column …

[zratkai]

What changes were proposed in this pull request?

This PR fixes issue : "ORC doesn't handle primitive category TIMESTAMPLOCALTZ".

Why are the changes needed?

Fix TIMESTAMPLOCALTZ type handling.

Does this PR introduce any user-facing change?

Yes, if user has a table containing timestamp column with default defined using TIMESTAMPLOCALTZ it fixes the ORC doesn't handle primitive category TIMESTAMPLOCALTZ" exception-

How was this patch tested?

Jenkins pipeline.

[InvisibleProgrammer]

I have some extra thoughts about the tests:

There are two changes in the code: I think one for generic execution and one for vectorised. But I think the test only tests one of them.

And the test tests a lot of column types. But only the local timestamp column is affected on the change.
I don't remember to the exact location but I think I saw some test that involves all column types.

I would suggest creating (or finding an existing) vectorised test as well and also check if is there an existing checking all type of columns like test to extend.

Or, if the test is necessary to reproduce the issue, I would love seeing the ticket number on the top of the qtest file, as a comment.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
No Duplication information

[zratkai]

he code: I think one for generic execution and one for vectoris

This is not the case. During the test both code changes are executed /tested. Ticket number is visible in git history for this file. It is very rare that a q test file contains the ticket number, I don't see any benefit.

[deniskuzZ]

LGTM +1